Skip to content
This repository was archived by the owner on Jan 24, 2024. It is now read-only.

[feature]:issue15 - add try-catch for run migrations#16

Merged
wolfy-j merged 3 commits intospiral-modules:masterfrom
EvgenyBarinov:feature/issue15
Jun 5, 2020
Merged

[feature]:issue15 - add try-catch for run migrations#16
wolfy-j merged 3 commits intospiral-modules:masterfrom
EvgenyBarinov:feature/issue15

Conversation

@EvgenyBarinov
Copy link
Contributor

Fix for issue15

@wolfy-j
Copy link
Member

wolfy-j commented Jun 3, 2020

Any tests for it?

@EvgenyBarinov
Copy link
Contributor Author

Tests were modified.
Error patterns were used from PR12 thanks for @aywan .

@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #16 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #16      +/-   ##
============================================
+ Coverage     98.16%   98.18%   +0.02%     
- Complexity      232      233       +1     
============================================
  Files            29       29              
  Lines           763      772       +9     
============================================
+ Hits            749      758       +9     
  Misses           14       14              
Impacted Files Coverage Δ Complexity Δ
src/Migrator.php 97.43% <100.00%> (+0.33%) 25.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79368bc...7a47497. Read the comment docs.

@EvgenyBarinov EvgenyBarinov marked this pull request as ready for review June 5, 2020 06:14
@wolfy-j wolfy-j merged commit 3c298d0 into spiral-modules:master Jun 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants