Expose flush() method on Logback and Log4j appenders to flush underlying HttpEventCollectorSender and OkHttpClient#207
Merged
vmalaviya-splunk merged 3 commits intosplunk:mainfrom Feb 1, 2022
Conversation
stevejagodzinski
changed the title
Author
|
The failing checks seem un-related to the changes in this MR. Perhaps the CI pipeline is unstable? #210 aims to debug this pipeline failure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build upon the previous partial solution to #152
Instead of stopping the appender at then end of a lambda function, just call
flush()on the appender.This way the appender can be re-used next time the lambda function is invoked.
The underlying httpClient is flushed (up to the configured timeout).