Resend middleware to retry also for some HTTP error codes#287
Open
simonhege wants to merge 1 commit intosplunk:mainfrom
Open
Resend middleware to retry also for some HTTP error codes#287simonhege wants to merge 1 commit intosplunk:mainfrom
simonhege wants to merge 1 commit intosplunk:mainfrom
Conversation
jcjveraa
approved these changes
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some HTTP errors are worth to retry, especially when indexer is behind a proxy/load-balancer.
This PR applies the same strategy for retries in the Java client compared to the dotnet one:
https://github.com/splunk/splunk-library-dotnetlogging/blob/master/src/Splunk.Logging.Common/HttpEventCollectorResendMiddleware.cs