You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR allows scope: cluster on standalone CRDs, and thus allowing to be installed in the /etc/deployment-apps dir
Key Changes
Modifying standalone CRDs to allow scope: cluster (as well as scope: local, where behavior is unchanged)
This will now allow us to install to /etc/deployment-apps
Testing and Verification
Ran operator and automation locally, however still in the process of manually verifying the changes. Just creating this PR to start getting review on work.
It would be good to add a test case to the appframeworksS1 test suite that includes an app deployed to the cluster scope, or possibly even add to one of the existing test cases with the cluster scope for a new app.
There are also some existing unit tests in standalone_test.go that are related to appframework that we should add to as well to test both the local and cluster scoped apps.
It would be good to add a test case to the appframeworksS1 test suite that includes an app deployed to the cluster scope, or possibly even add to one of the existing test cases with the cluster scope for a new app.
There are also some existing unit tests in standalone_test.go that are related to appframework that we should add to as well to test both the local and cluster scoped apps.
I agree. We need to add new test cases. Also, I believe that automated tests are not enough and some portion of manual tests is required for both local and cluster scopes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR allows scope: cluster on standalone CRDs, and thus allowing to be installed in the /etc/deployment-apps dir
Key Changes
Testing and Verification
Ran operator and automation locally, however still in the process of manually verifying the changes. Just creating this PR to start getting review on work.
Related Issues
Jira: https://splunk.atlassian.net/browse/CSPL-3532
GHI: #1180
PR Checklist