CSPL-4358 Split BusConfiguration CR into 2 CRs - Queue and ObjectStorage by kasiakoziol · Pull Request #1643 · splunk/splunk-operator

kasiakoziol · 2025-12-12T12:37:03Z

Depends On

Feature/CSPL-4360 Secret reference for Index & Ingestion separation #1649

Description

It splits BusConfiguration CR into 2 CRs - Queue and ObjectStorage as per internal documentation.

Key Changes

New CRs - Queue and ObjectStorage
Validations added to new CRs
Updated documentation and Helm charts

Testing and Verification

Manual tests
Automated tests

Related Issues

Jira: https://splunk.atlassian.net/browse/CSPL-4358

PR Checklist

Code changes adhere to the project's coding standards.
Relevant unit and integration tests are included.
Documentation has been updated accordingly.
All tests pass locally.
The PR description follows the project's guidelines.

coveralls · 2025-12-12T12:50:02Z

Pull Request Test Coverage Report for Build 21815575593

Details

236 of 523 (45.12%) changed or added relevant lines in 11 files are covered.
14 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-1.4%) to 83.986%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/splunk/enterprise/types.go	0	4	0.0%
pkg/splunk/enterprise/upgrade.go	0	4	0.0%
pkg/splunk/enterprise/objectstorage.go	31	40	77.5%
pkg/splunk/enterprise/queue.go	31	40	77.5%
pkg/splunk/enterprise/ingestorcluster.go	96	117	82.05%
pkg/splunk/enterprise/util.go	14	35	40.0%
internal/controller/indexercluster_controller.go	2	63	3.17%
internal/controller/ingestorcluster_controller.go	2	63	3.17%
pkg/splunk/enterprise/indexercluster.go	58	155	37.42%

Files with Coverage Reduction	New Missed Lines	%
internal/controller/indexercluster_controller.go	7	38.1%
internal/controller/ingestorcluster_controller.go	7	38.46%

Totals
Change from base Build 19886830069:	-1.4%
Covered Lines:	11223
Relevant Lines:	13363

💛 - Coveralls

…PL-4360-secret-ref-ingest-index

api/v4/indexercluster_types.go

internal/controller/queue_controller.go

pkg/splunk/enterprise/util.go

pkg/splunk/enterprise/indexercluster.go

pkg/splunk/enterprise/ingestorcluster.go

pkg/splunk/enterprise/indexercluster.go

…ollers

vivekr-splunk · 2026-02-06T13:12:17Z

api/v4/objectstorage_types.go

+	// +optional
+	// +kubebuilder:validation:Pattern=`^https?://[^\s/$.?#].[^\s]*$`
+	// S3-compatible Service endpoint
+	Endpoint string `json:"endpoint"`


are we expecting the endpoint to have the region. do we need region separately.

ObjectStorage doesn't have region field, relies on Path. But if Endpoint is constructed automatically somewhere, same China/GovCloud issue from PR

The region in ObjectStorage is taken from Queue if it is provided over there

api/v4/queue_types.go

vivekr-splunk · 2026-02-06T13:17:45Z

api/v4/objectstorage_types.go

+	// +kubebuilder:validation:Required
+	// +kubebuilder:validation:Pattern=`^s3://[a-z0-9.-]{3,63}(?:/[^\s]+)?$`
+	// S3 bucket path
+	Path string `json:"path"`


do we need s3:// when we know we are already in S3Spec

That's sth to consider. I am fine with both. For app repo or smart store, we are not requiring this, so maybe we should make it consistent.

vivekr-splunk

i have approve with comments

vivekr-splunk

approved with comments

kasiakoziol · 2026-02-09T07:04:26Z

From Vivek: we should have clear names and mixes concern queue , bucket, access, secret, version. can we try something simple like CredentialSecretVersion

…est-index Feature/CSPL-4360 Secret reference for Index & Ingestion separation

kasiakoziol added 3 commits December 12, 2025 12:30

CSPL-4358 Splitting BusConfiguration into Bus and LargeMessageStore

c1ad439

CSPL-4358 Update docs

cb8daf2

CSPL-4358 Addressing comments

61c0387

kasiakoziol added 15 commits December 15, 2025 10:47

CSPL-4358 Adding more validations

3eb98f7

CSPL-4360 Secret reference added for Bus CR

254cbf0

CSPL-4360 Fix failing tests

f992c40

CSPL-4360 Add Splunk restart

143dbe0

CSPL-4360 Fix failing tests

3c7b2d7

CSPL-4360 Fix failing tests

e4e083a

CSPL-4360 Fix errors with failing validation on status

3cb9148

CSPL-4358 Rename Bus to Queue

ba73a87

CSPL-4358 Rename LargeMessageStore to ObjectStorage

b6f5b0b

CSPL-4358 Making region authRegion and optional, simplifying endpoint

607632f

Merge branch 'feature/CSPL-4358-split-bus-into-2-crs' into feature/CS…

30a82c6

…PL-4360-secret-ref-ingest-index

CSPL-4360 Fixing tests after merge

fafed27

CSPL-4360 Fix validation that fails for status

e0a10ba

CSPL-4360 Fix failing to get k8s secret

155b21a

CSPL-4360 Fix failing integ and helm tests

f8afd5a

kasiakoziol changed the title ~~CSPL-4358 Split BusConfiguration CR into 2 CRs - Bus and LargeMessageStore~~ CSPL-4358 Split BusConfiguration CR into 2 CRs - Queue and ObjectStorage Dec 23, 2025

kasiakoziol mentioned this pull request Dec 23, 2025

[DO NOT MERGE BEFORE #1606 and #1610] CSPL-3549 Splunk Operator Enhancement – Ingestion and Indexing Separation #1550

Open

5 tasks

kasiakoziol marked this pull request as ready for review December 23, 2025 14:20

kasiakoziol requested review from Igor-splunk, kubabuczak, patrykw-splunk, rlieberman-splunk and vivekr-splunk December 23, 2025 14:22

rlieberman-splunk reviewed Jan 8, 2026

View reviewed changes

api/v4/indexercluster_types.go Show resolved Hide resolved

rlieberman-splunk approved these changes Jan 8, 2026

View reviewed changes

CSPL-4360 Fixing failing tests due to incorrect secret ref

47d1a35

vivekr-splunk reviewed Jan 12, 2026

View reviewed changes

internal/controller/queue_controller.go Outdated Show resolved Hide resolved

pkg/splunk/enterprise/util.go Show resolved Hide resolved

vivekr-splunk reviewed Jan 13, 2026

View reviewed changes

pkg/splunk/enterprise/indexercluster.go Outdated Show resolved Hide resolved

kasiakoziol added 6 commits January 13, 2026 11:36

CSPL-4360 Addressing comments

532ca28

CSPL-4360 Addressing secret value change and removing redundant contr…

5c6e786

…ollers

CSPL-4360 Update of docs, helm tests and validations

42dc8e8

CSPL-4360 Add secret watch and fix controller tests

c50984b

CSPL-4360 Update docs

e81280c

CSPL-4360 Restart Splunk when SA changed

d29aed1

vivekr-splunk reviewed Feb 6, 2026

View reviewed changes

vivekr-splunk approved these changes Feb 6, 2026

View reviewed changes

Merge pull request #1649 from splunk/feature/CSPL-4360-secret-ref-ing…

52ff612

…est-index Feature/CSPL-4360 Secret reference for Index & Ingestion separation

Conversation

kasiakoziol commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Depends On

Description

Key Changes

Testing and Verification

Related Issues

PR Checklist

Uh oh!

coveralls commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 21815575593

Details

💛 - Coveralls

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vivekr-splunk Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

vivekr-splunk Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

kasiakoziol Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vivekr-splunk Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

kasiakoziol Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

vivekr-splunk left a comment

Choose a reason for hiding this comment

Uh oh!

vivekr-splunk left a comment

Choose a reason for hiding this comment

Uh oh!

kasiakoziol commented Feb 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kasiakoziol commented Dec 12, 2025 •

edited

Loading

coveralls commented Dec 12, 2025 •

edited

Loading