SPL-290976: KVService controller flow for deployment #1683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adding controller flow
Contributor
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Collaborator
Author
|
I have read the CLA Document and I hereby sign the CLA |
Collaborator
Author
|
I have read the Code of Conduct and I hereby accept the Terms |
sgontla
changed the title
rlieberman-splunk
approved these changes
Feb 9, 2026
jmsplunk
reviewed
Feb 9, 2026
| spec: | ||
| description: KVServiceSpec defines the desired state of KVService | ||
| properties: | ||
| foo: |
Collaborator
There was a problem hiding this comment.
seems we need to re-generate from the kvservice_types.go?
| return service | ||
| } | ||
|
|
||
| // getKVServiceStatefulSet returns a Kubernetes StatefulSet object for Splunk Enterprise standalone instances. |
Collaborator
There was a problem hiding this comment.
nit: StatefulSet -> deployment
| "sigs.k8s.io/controller-runtime/pkg/reconcile" | ||
| ) | ||
|
|
||
| // ApplyKVService reconciles the StatefulSet for N standalone instances of Splunk Enterprise. |
Collaborator
There was a problem hiding this comment.
nit: comment needs to be fixed
| } | ||
|
|
||
| // validateKVServiceSpec checks validity and makes default updates to a KVServiceSpec, and returns error if something is wrong. | ||
| func validateKVServiceSpec(ctx context.Context, c splcommon.ControllerClient, cr *enterpriseApi.KVService) error { |
Collaborator
There was a problem hiding this comment.
wondering is there anything we need to change in the createKVServiceCR function to pass this validation function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What does this PR have in it?
Key Changes
Highlight the updates in specific files
Testing and Verification
KVService deployment comes up, but pod fails at this time, which is expected, as we need to bring in other supporting changes like the kvservice config in single tenant mode, and also needs db connectivity for the probes to succeed:
Related Issues
Jira tickets, GitHub issues, Support tickets...
PR Checklist