This repository was archived by the owner on Jul 17, 2019. It is now read-only.
[avro] Fixes bug with references to namespaced schemas #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a namespaced subrecord that is referenced twice in a schema would correctly get a schema in the first reference. But in the second reference where it's only supposed to be a namespace + name, the namespace was omitted, causing problems when parsing the schema
Contributor
Author
|
This needs some tests, but I think the patch itself is sane. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a namespaced subrecord that is referenced twice in a schema
would correctly get a schema in the first reference. But in the second
reference where it's only supposed to be a namespace + name, the namespace
was omitted, causing problems when parsing the schema