This repository was archived by the owner on Apr 4, 2022. It is now read-only.
Removes EtcdLifecycle in favor of AutoRegistration and ServiceRegistry APIs#43
Open
venilnoronha wants to merge 2 commits intospring-attic:mainfrom
Open
Removes EtcdLifecycle in favor of AutoRegistration and ServiceRegistry APIs#43venilnoronha wants to merge 2 commits intospring-attic:mainfrom
venilnoronha wants to merge 2 commits intospring-attic:mainfrom
Conversation
spencergibb
suggested changes
Apr 13, 2017
| org.springframework.cloud.etcd.discovery.RibbonEtcdAutoConfiguration | ||
|
|
||
| # Discovery Client Configuration | ||
| org.springframework.cloud.client.discovery.EnableDiscoveryClient=\ |
Collaborator
There was a problem hiding this comment.
hmm, gonna need this still.
Contributor
Author
|
Does it look okay now? |
spencergibb
reviewed
Aug 22, 2017
| public EtcdLifecycle etcdLifecycle() { | ||
| return new EtcdLifecycle(client, etcdDiscoveryProperties()); | ||
| @ConditionalOnMissingBean | ||
| public TtlScheduler ttlScheduler(EtcdDiscoveryProperties properties) { |
Collaborator
There was a problem hiding this comment.
Can you explain why this is needed? Etcd has a ttl built in.
Contributor
Author
There was a problem hiding this comment.
I thought we would want to mark the service's availability via a heartbeat. What's the alternative?
Collaborator
There was a problem hiding this comment.
You're right, How about renaming it using Heartbeat.
qiyi
added a commit
to qiyi/spring-cloud-etcd
that referenced
this pull request
Mar 3, 2018
….0.RELEASE and Spring Cloud 2.0.0.x, spring-attic#46 1. Change the version to 2.0.0.BUILD-SNAPSHOT 2. Merge the spring-attic#43 from @venilnoronha for the EtcdLifecycle can't work now 3. Upgrade the etcd version to v3.3.1 for ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR removes the existing EtcdLifecycle while adding an implementation based on the AutoRegistration and ServiceRegistry APIs. See #36 for more info.
Please review and pull.
Thanks,
Venil