Skip to content

Document that use of non idiomatic format for '@Value' still apply for environment variables#49054

Closed
linkian209 wants to merge 1 commit intospring-projects:mainfrom
linkian209:main
Closed

Document that use of non idiomatic format for '@Value' still apply for environment variables#49054
linkian209 wants to merge 1 commit intospring-projects:mainfrom
linkian209:main

Conversation

@linkian209
Copy link
Contributor

@linkian209 linkian209 commented Feb 3, 2026

This patch makes a small change to the documentation for External Configuration regarding how @Value behaves with camelCase variables and environment variables.

I created a demo application that illustrates that variables that are defined using camelCase and injected using @Value not in the canonical form will pickup values from environment variables.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 3, 2026
@snicoll
Copy link
Member

snicoll commented Feb 4, 2026

Thanks for the PR, but the line above your change has already that exact comment:

as well as DEMO_ITEMPRICE from the system environment.

@snicoll snicoll closed this Feb 4, 2026
@snicoll snicoll added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 4, 2026
@snicoll
Copy link
Member

snicoll commented Feb 4, 2026

@wilkinsona made me aware that I read the wrong line, sorry about that.

@snicoll snicoll reopened this Feb 4, 2026
@snicoll
Copy link
Member

snicoll commented Feb 4, 2026

@linkian209 we need you to sign-off your commit as the DCO check fails at the moment. Can you please do that?

@snicoll snicoll added status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged and removed status: declined A suggestion or change that we don't feel we should currently apply labels Feb 4, 2026
This patch makes a small change to the documentation for External Configuration regarding how @value behaves with camelCase variables and environment variables.

Signed-off-by: Ian Drake <linkian209@gmail.com>
@linkian209
Copy link
Contributor Author

@linkian209 we need you to sign-off your commit as the DCO check fails at the moment. Can you please do that?

Sorry about that! Done.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Feb 4, 2026
@snicoll snicoll added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged status: feedback-provided Feedback has been provided labels Feb 5, 2026
@snicoll snicoll self-assigned this Feb 5, 2026
@snicoll snicoll changed the title External Config Doc Update Document that use of non idiomatic format for '@Value' still apply for environment variables Feb 5, 2026
@snicoll snicoll added this to the 3.5.11 milestone Feb 5, 2026
snicoll pushed a commit that referenced this pull request Feb 5, 2026
See gh-49054

Signed-off-by: Ian Drake <linkian209@gmail.com>
@snicoll snicoll closed this in 711f96d Feb 5, 2026
@snicoll
Copy link
Member

snicoll commented Feb 5, 2026

Thanks @linkian209. We had a similar note for the binding in general so I've updated that as well in a polish commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: documentation A documentation update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants