Remove reflection in AutoConfigurationChecker #getConfigurations#49058
Open
GaetanoCerciello wants to merge 1 commit intospring-projects:mainfrom
Open
Remove reflection in AutoConfigurationChecker #getConfigurations#49058GaetanoCerciello wants to merge 1 commit intospring-projects:mainfrom
GaetanoCerciello wants to merge 1 commit intospring-projects:mainfrom
Conversation
Contributor
|
Yes, this change makes sense and works, thanks! Please sign off your commit. |
25c383b to
16dd10a
Compare
Signed-off-by: producer <producer@MacBookPro.home> Signed-off-by: Gaetano Cerciello <cerciello980@gmail.com>
16dd10a to
7fc299e
Compare
Author
|
@mhalbritter Changes made:
The commit now includes the required sign-off and is ready for merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request removes the use of reflection in
AutoConfigurationChecker#getConfigurations()and replaces it with a direct approach using ArchUnit's public API.Problem
The
AutoConfigurations#getConfigurations()method was using reflection to access a privateJavaClasses.of()factory method: