HTTP request snippet for PATCH, POST and PUT requests with no body has an incorrectly inferred Content-Type header#1018
Open
banseok1216 wants to merge 1 commit intospring-projects:mainfrom
Conversation
33a16d3 to
8467729
Compare
Member
|
Thanks for the PR. Setting the |
8ef4042 to
ba17f1c
Compare
Contributor
Author
|
Thanks for the feedback. The PR has been updated as suggested. |
…out body Signed-off-by: banseok1216 <bansuk1216@naver.com>
ba17f1c to
ec21a0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1017
Summary
REST Docs previously inferred Content-Type: application/x-www-form-urlencoded
when processing POST/PUT/PATCH requests that had no Content-Type, no body, and no parts.
This caused the generated documentation to differ from the real request seen by Spring MVC.
What this PR changes
application/x-www-form-urlencodedproduce no Content-Type header in the generated snippet
Rationale
Documentation should reflect the exact request sent by the client.
HTTP provides no default media type, and Spring MVC does not infer one.
Avoiding implicit Content-Type injection ensures accuracy and prevents misleading API documentation.