Update Rack apps for 1.9.2#63
Open
maxhawkins wants to merge 1 commit intosproutcore:masterfrom
maxhawkins:master
Open
Update Rack apps for 1.9.2#63maxhawkins wants to merge 1 commit intosproutcore:masterfrom maxhawkins:master
maxhawkins wants to merge 1 commit intosproutcore:masterfrom
maxhawkins:master
Conversation
String#each was removed in Ruby 1.9.2. The content returned by a rack app must respond to #each.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into some trouble while trying to use sproutcore with pow.cx. I added this config.ru to my sproutcore project
But ran into errors while trying to fetch "/sc/targets.json"
It turns out the rack app that serves that file was passing a raw string as content and strings don't respond to #each as of 1.9.2 so it choked. This change makes SC::Rack::Dev and all of the other Rack apps in abbot that return a string return an array instead.
Sorry there aren't any failing tests. I couldn't find a convenient place to add them. All of the tests still pass.