Restoring source for SCCompile.jar and rebuilding to target Java 1.5#73
Open
mitchless wants to merge 2 commits intosproutcore:masterfrom
Open
Restoring source for SCCompile.jar and rebuilding to target Java 1.5#73mitchless wants to merge 2 commits intosproutcore:masterfrom
mitchless wants to merge 2 commits intosproutcore:masterfrom
Conversation
Member
|
why do you want support for java 1.5, it was released 7 years ago. SCCompiler.jar was brought back because we had several regressions, with the new code. I'm looking into refactoring this code to improve minification. |
Author
Because my build environment provides support for Linux as far back as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Back in April the source for SCCompile.jar was removed from github, and then back in July alexiskander added the jar back in, with a target version of Java 1.6 without restoring the source.
I've added the source back and rebuilt SCCompile.jar with a target version of Java 1.5. The build process my company uses Java 1.5, hence the change. I don't know if alexiskander made any untracked changes that were included in his build. If so, they'll need to be reincorporated into SCCompile.jar. I'm willing to update my branch to make that happen and resubmit the pull, but I'll need to know what changes to make.