You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Content Filters
Adds a new abstract file type BT.CodeFile with content filtering support implemented via a BT.ContentFiltersMixin.
With content filtering mixed in, a chain of filters may be defined for a processable file with purpose of parsing, replacing known fragments or any other kind of processing.
sc_static() / static_url() support
Implemented as JavaScript functions in node-sass.
all targets are inserted into the file's resourceDependencies, so linked resources would be processed in BUILD run mode.
Dependency tree
All @import's in .scss files are intercepted and a tree of dependencies is maintained.
Updating an imported file leads to the update of all master files on top of its dependency chain.
I like the idea a lot, because I see its value for the script files as well as base class for scripts and styles of any kind. I am unsure about this implementation.
First of all, the class name is a bit vague, BT.FilteredFile would be better IMHO.
Secondly, I think that this doesn't need to be done through mixins, mainly because if the normal extending procedure is used, you can use concatenatedProperties (http://docs.sproutcore.com/#doc=SC.Object&method=concatenatedProperties&src=false) to automatically attach new filtering to the end of the filtering procedure.
Moreover, if the filters themselves are implemented as cached computed properties, it could mean a speed up for any processed file.
The purpose of the class itself is to simply apply all the filters in a row.
Thoughts?
I thinks we should also move most of the BT.CSSFile logic into BT.SCSSFile, and extend BT.CSSFile from BT.SCSSFile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content Filters
Adds a new abstract file type
BT.CodeFilewith content filtering support implemented via aBT.ContentFiltersMixin.With content filtering mixed in, a chain of filters may be defined for a processable file with purpose of parsing, replacing known fragments or any other kind of processing.
sc_static()/static_url()supportImplemented as JavaScript functions in node-sass.
all targets are inserted into the file's
resourceDependencies, so linked resources would be processed inBUILDrun mode.Dependency tree
All
@import's in .scss files are intercepted and a tree of dependencies is maintained.Updating an imported file leads to the update of all master files on top of its dependency chain.