My First Contribution to the SC Documentation Effort - Guide to the signup app#2
Open
ahawkins wants to merge 1 commit intosproutcore:masterfrom
ahawkins:master
Open
My First Contribution to the SC Documentation Effort - Guide to the signup app#2ahawkins wants to merge 1 commit intosproutcore:masterfrom ahawkins:master
ahawkins wants to merge 1 commit intosproutcore:masterfrom
ahawkins:master
Conversation
Member
|
sure I'll take a look at it |
Contributor
|
What's the status on this? |
Member
|
There's a lot of value in this document, and I (belatedly) suggest we include it. I don't expect similar documents to be created for each demo, but there's no reason to not capture this free value. I glanced over the content very briefly didn't see any issues. |
Member
|
At a glance, the only major issue is that it hasn't been updated to use SC.Statechart. We should polish this into an updated demo to add to the Showcase, including invalid username/password handling and maybe some other niceties like remembering the last successful username, etc. I don't mind taking this on, I have a lot of experience with the Showcase demos. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I posted earlier on the dev mailing list about writing 'how it works' guides for the sample apps. I've completed my first one. I've written a guide for the signup application in markdown. I've setup a structure in /doc/app_name to store the docs. Can you read it and check it out to make sure I have all the jargon correct?