Quilmes #8
Open
Quilmes #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…container views inside of it, rather than just its own direct descendant
… make it easier to subclass
…ccurred within it
…ctionality should be fine)
…ing for class names in tests work
…rough SC.PolymorphicSingleAttribute
…ar too fast). -- fix courtesy stillmotion
…ssue where going back to a view that had already been scrolled did not display its correct position
…class names, e.g., if controlsHidden changed to false, the controls-hidden class would not be removed
Contributor
|
This all loooks good to me. Though I think someone else should review it since there are a lot of changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes I've made. The only thing I would think that won't be ready for primetime is the polymorphic relationship stuff.