Conversation
Owner
|
I can't accept this until coding standards sniff passes. See travis build log for details. |
ghost
mentioned this pull request
neoteknic
added a commit
to neoteknic/Phue
that referenced
this pull request
Jan 11, 2018
sqmk#130 Fix color higher than 255
ghost
pushed a commit
to wearebuilders/Phue
that referenced
this pull request
May 1, 2018
- fixed coding standards in color conversion tool. - added unit test for the 0..255 range fix.
neoteknic
added a commit
to neoteknic/Phue
that referenced
this pull request
May 19, 2018
…gher-than-255 sqmk#130 Fix color higher than 255
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More info at : #114
I have put a condition for prohid color higher than 255