Skip to content

Fix brigthness#133

Open
neoteknic wants to merge 1 commit intosqmk:masterfrom
neoteknic:patch-1
Open

Fix brigthness#133
neoteknic wants to merge 1 commit intosqmk:masterfrom
neoteknic:patch-1

Conversation

@neoteknic
Copy link

The most accurate way to set brigthness for RGB, is to alway take the max R,G,B value (If you try a colorpicker, you set 150, 43,56, and you change only the hue, you alway have 150 on R, G or B, and brigthness will not change.
exemaple : With RGB (0 ,0, 255) you expect a 100% brigth blue so bri = 255
If you take Y you have a wrong very low blue (4,7% brightness).

The most accurate way to set brigthness for RGB, is to alway take the max R,G,B value (If you try a colorpicker, you set 150, 43,56, and you change only the hue, you alway have 150 on R, G or B, and brigthness will not change.
exemaple : With RGB (0 ,0, 255) you expect a 100% brigth blue so bri = 255
If you take Y you have a wrong very low blue (4,7% brightness).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant