This repository was archived by the owner on Feb 7, 2020. It is now read-only.
Open
Conversation
Contributor
There was a problem hiding this comment.
Hmm, not quite as concise as the command line and Cocaine, but it reads fairly well and is less arcane. So on the whole I like it.
Contributor
|
Ran the tests for this branch on my Ubuntu 12.4 system, and they worked fine. Looks good to me. |
Contributor
Author
|
Thanks for testing this on Ubuntu Jim! |
Merged
robolson
added a commit
that referenced
this pull request
Oct 29, 2015
* commit '48858b65af6ca25480d0145d5df1d0278b221dd7': DB config for staging environment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@robolson @square/kochiku-contributors this is a first pass at switching out one of the cocaine calls for rugged.
@cheister I am not sure if I have maintained the order of the original method?
I am not thrilled about
repo.last_commit.parents.first.parents.first.oidbut I could not find an easy way to grab the first commit from rugged. Do you guys see something obvious that I missed?Also wasn't super thrilled about locking to development (basically master) of rugged but the last release is pretty far behind development: libgit2/rugged@7f408b8...development