fix(menus): ban length optimisation #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced the loop in DisplayLengths_Menu with explicit AddLength calls for each ban duration - Improving clarity and maintainability. - Updated KnockbackRestrict.inc patch version from 4.0.5 to 4.0.6.
There was a problem hiding this comment.
Pull request overview
This PR refactors the ban duration menu by replacing a loop-based approach with explicit AddLength calls for each ban duration option. The change aims to improve code clarity and maintainability while adjusting the available ban duration options.
Changes:
- Replaced the for-loop in
DisplayLengths_Menuwith explicitAddLengthcalls - Modified available ban durations (removed some options, added 4-month option)
- Incremented patch version from 4.0.5 to 4.0.6
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| addons/sourcemod/scripting/include/KnockbackRestrict.inc | Version bump from 4.0.5 to 4.0.6 |
| addons/sourcemod/scripting/helpers/menus.sp | Replaced loop with explicit AddLength calls for ban durations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/NiDE-gg/ze-configs-private/issues/121