Skip to content

Comments

Feat/render profile#100

Closed
AritraDey-Dev wants to merge 2 commits intosristy17:dwoc-2025from
AritraDey-Dev:feat/render-profile
Closed

Feat/render profile#100
AritraDey-Dev wants to merge 2 commits intosristy17:dwoc-2025from
AritraDey-Dev:feat/render-profile

Conversation

@AritraDey-Dev
Copy link
Contributor

Fixes Issue

Closes #98

Changes proposed

  • Implemented user data handling during signup and signin processes.
  • Stored user information in the session after successful signup and signin.
  • Redirected users to the profile page upon successful authentication.
  • Updated the profile page to render user information correctly.
  • Added toast notifications for user feedback during signup and signin processes.

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Screencast.from.2025-02-08.15-35-04.webm

Note to reviewers

Please review the changes related to user authentication and profile rendering. Feedback on the session management and redirect logic would be appreciated.

Copy link
Owner

@sristy17 sristy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @AritraDey-Dev! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@AritraDey-Dev
Copy link
Contributor Author

@pooranjoyb @sristy17 this is the PR that solves #98.please look into this and inform if any change you feel required.

@pooranjoyb pooranjoyb added enhancement New feature or request dwoc-2025 Issue under DWOC 2025 level 4 labels Feb 8, 2025
Copy link
Collaborator

@pooranjoyb pooranjoyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API level changes weren't requested in the issue, you just needed to modify the params and render them in the profile. However you changed the entire workflow. Please look into it and revert any unnecessary changes if need be or you can close this PR and raise a fresh one.

@AritraDey-Dev

@AritraDey-Dev
Copy link
Contributor Author

AritraDey-Dev commented Feb 9, 2025

API level changes weren't requested in the issue, you just needed to modify the params and render them in the profile. However you changed the entire workflow. Please look into it and revert any unnecessary changes if need be or you can close this PR and raise a fresh one.

@AritraDey-Dev
Screenshot from 2025-02-09 16-04-41
here in signup while doing signup we are not storing anything in that session previously so basically even if you are logged in as there is nothing stored in that session we can't know the user is logged in.so after looking into it and this thing
Screenshot from 2025-02-09 16-05-31
I have added that particular data in that session.
And like you told we can add params to fetch the user info ,for that we need the id which we can store either using jwt or cookies session.Or we can directly call the db to fetch it which i feel is not a good idea as we are calling the db again and again.So do you have any different idea on that...at least we need a local storage and cookies store store this thing.I used cookies as that thing already used in the codebase.

@sristy17
Copy link
Owner

sristy17 commented Feb 9, 2025

API level changes weren't requested in the issue, you just needed to modify the params and render them in the profile. However you changed the entire workflow. Please look into it and revert any unnecessary changes if need be or you can close this PR and raise a fresh one.
@AritraDey-Dev
Screenshot from 2025-02-09 16-04-41
here in signup while doing signup we are not storing anything in that session previously so basically even if you are logged in as there is nothing stored in that session we can't know the user is logged in.so after looking into it and this thing
Screenshot from 2025-02-09 16-05-31
I have added that particular data in that session.
And like you told we can add params to fetch the user info ,for that we need the id which we can store either using jwt or cookies session.Or we can directly call the db to fetch it which i feel is not a good idea as we are calling the db again and again.So do you have any different idea on that...at least we need a local storage and cookies store store this thing.I used cookies as that thing already used in the codebase.

Didn't you handled sign in?

@AritraDey-Dev
Copy link
Contributor Author

API level changes weren't requested in the issue, you just needed to modify the params and render them in the profile. However you changed the entire workflow. Please look into it and revert any unnecessary changes if need be or you can close this PR and raise a fresh one.
@AritraDey-Dev
Screenshot from 2025-02-09 16-04-41
here in signup while doing signup we are not storing anything in that session previously so basically even if you are logged in as there is nothing stored in that session we can't know the user is logged in.so after looking into it and this thing
Screenshot from 2025-02-09 16-05-31
I have added that particular data in that session.
And like you told we can add params to fetch the user info ,for that we need the id which we can store either using jwt or cookies session.Or we can directly call the db to fetch it which i feel is not a good idea as we are calling the db again and again.So do you have any different idea on that...at least we need a local storage and cookies store store this thing.I used cookies as that thing already used in the codebase.

Didn't you handled sign in?
ok i was thinking to store the data after signup itself.Basically it gives good user signup experience.We can do it like you told after signin we will store that in that session.So it will redirect to signin route after signup.Should i proceed with that?

@AritraDey-Dev
Copy link
Contributor Author

@pooranjoyb @sristy17 I am closing this PR,I did some very bad mistake in that.I will create a new PR for the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dwoc-2025 Issue under DWOC 2025 enhancement New feature or request level 4

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Rendering Profile Information

3 participants