Skip to content

Comments

Feat/render profile info#101

Merged
sristy17 merged 1 commit intosristy17:dwoc-2025from
AritraDey-Dev:feat/render-profile-info
Feb 18, 2025
Merged

Feat/render profile info#101
sristy17 merged 1 commit intosristy17:dwoc-2025from
AritraDey-Dev:feat/render-profile-info

Conversation

@AritraDey-Dev
Copy link
Contributor

@AritraDey-Dev AritraDey-Dev commented Feb 9, 2025

Fixes Issue #98

Changes proposed

  • Updated the user form EJS template to point to the new login route.
  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Screencast.from.2025-02-10.04-11-41.webm

Copy link
Owner

@sristy17 sristy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @AritraDey-Dev! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@AritraDey-Dev
Copy link
Contributor Author

@pooranjoyb @sristy17 I have fixed the issue and also i added the whole user data in that session.we can add a database call directly,but i feel that is not a good idea to implement as we are storing that in that session.if you want i can go with that approach.Please share your idea on that.

Copy link
Owner

@sristy17 sristy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good! @pooranjoyb have a look.

Also @AritraDey-Dev it is not validating the schema of phone number even >10 digits on phone number is working, look into this

@sristy17 sristy17 added dwoc-2025 Issue under DWOC 2025 level 3 labels Feb 13, 2025
@AritraDey-Dev
Copy link
Contributor Author

Added zod validation schemas for user signup and signin to ensure proper data validation (controllers/auth.controller.js).

Screencast.from.2025-02-13.14-46-18.webm

@AritraDey-Dev AritraDey-Dev force-pushed the feat/render-profile-info branch 3 times, most recently from 23cb2b2 to ce2a866 Compare February 15, 2025 21:36
@AritraDey-Dev
Copy link
Contributor Author

Screenshot from 2025-02-17 02-02-23

@pooranjoyb pooranjoyb self-requested a review February 17, 2025 06:27
Copy link
Collaborator

@pooranjoyb pooranjoyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Please review and merge @sristy17 if fine.

@sristy17 sristy17 merged commit b8ccb62 into sristy17:dwoc-2025 Feb 18, 2025
@AritraDey-Dev AritraDey-Dev deleted the feat/render-profile-info branch April 17, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dwoc-2025 Issue under DWOC 2025 level 3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants