Feat/docker by AritraDey-Dev · Pull Request #104 · sristy17/MindDrive

AritraDey-Dev · 2025-02-13T15:04:44Z

Fixes Issue #103

Changes proposed

Set up the project using one single command(docker compose up -d --build)

Check List (Check all the applicable boxes)

My code follows the code style of this project.
My change requires changes to the documentation.
I have updated the documentation accordingly.
All new and existing tests passed.
This PR does not contain plagiarized content.
The title of my pull request is a short description of the requested changes.

Screenshots

sristy17

Great job, @AritraDey-Dev! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

sristy17

app crashed?

AritraDey-Dev · 2025-02-14T17:11:02Z

app crashed?

No I have tested the required things on my side after running docker compose.

sristy17 · 2025-02-14T17:21:53Z

app crashed?

No I have tested the required things on my side after running docker compose.

will see but it is crashing from my side while reviewing

AritraDey-Dev · 2025-02-14T17:32:08Z

app crashed?

No I have tested the required things on my side after running docker compose.

will see but it is crashing from my side while reviewing

yes a small change you have to do on your end.You have to add NODE_ENV=development
in your .env if you are running locally(Basically when you are using mongo db atlas as your db).

AritraDey-Dev · 2025-02-14T17:44:36Z

app crashed?

No I have tested the required things on my side after running docker compose.

will see but it is crashing from my side while reviewing

yes a small change you have to do on your end.You have to add NODE_ENV=development in your .env if you are running locally(Basically when you are using mongo db atlas as your db).

Should I create env.ex file for reference?

pooranjoyb · 2025-02-15T18:06:30Z

Dockerfile

If you're creating docker-compose.yaml then we don't need DockerFile

no we will still need it,otherwise it cann't build the docker image right.

No, it's nothing like that, both serve different use cases. The application is just one Node.js app with MongoDB and we don’t need to manage multiple containers or configurations separately, we can indeed just use a single Dockerfile for this. That's why I mentioned either use one. I'd suggest to go with Dockerfile

We will be running a single container (Node.js app + MongoDB), you can have the MongoDB container running directly using docker run as we have the connection handled directly within your Node.js app. Why to create a separate instance for MongoDB again.? Just go ahead with Dockerfile

Yeah how the repo is set up,your idea is correct I will just make a single dockerfile.

app.js

pooranjoyb · 2025-02-15T18:14:13Z

config/db.conf.js

You are already provided with creds for DB, you shouldn't hardcode it. If you wanna pass them them do it with env in docker-compose.

No like if we do docker compose up,then the db url will be mongodb://MindDrive:MindDrive@mongo:27017/dev-db?authSource=admin but if we look at db.conf.js file,it is taking the db url from there.
`export const DB_USER = process.env.DB_USER;
export const DB_PASSWORD = process.env.DB_PASSWORD;
export const DB_APPNAME = process.env.DB_APPNAME;

export const MONGODB_URI = mongodb+srv://${DB_USER}:${DB_PASSWORD}@dev-db.3tzynec.mongodb.net/?retryWrites=true&w=majority&appName=${DB_APPNAME};so when ever the user dodocker compose up -d ` it is not taking docker mogno db url it is taking from the db.conf file.So it will go down.

so i implemented it like this if someone mention NODE_ENV(which is not the case when you are doing docker compose) then it will take docker db url.Or if you are using set up like...
npm install followed by npm run dev in that case you have to add NODE_ENV in your .env.So that fixes the issue.Actually most of the cases we keep our db url in our .env which is not the case in this codebase.
I hope it helps.

No like if we do docker compose up,then the db url will be mongodb://MindDrive:MindDrive@mongo:27017/dev-db?authSource=admin but if we look at db.conf.js file,it is taking the db url from there. `export const DB_USER = process.env.DB_USER; export const DB_PASSWORD = process.env.DB_PASSWORD; export const DB_APPNAME = process.env.DB_APPNAME;

export const MONGODB_URI = mongodb+srv://${DB_USER}:${DB_PASSWORD}@dev-db.3tzynec.mongodb.net/?retryWrites=true&w=majority&appName=${DB_APPNAME};so when ever the user dodocker compose up -d ` it is not taking docker mogno db url it is taking from the db.conf file.So it will go down.

so i implemented it like this if someone mention NODE_ENV(which is not the case when you are doing docker compose) then it will take docker db url.Or if you are using set up like... npm install followed by npm run dev in that case you have to add NODE_ENV in your .env.So that fixes the issue.Actually most of the cases we keep our db url in our .env which is not the case in this codebase. I hope it helps.

@pooranjoyb what is your idea on this?

Here also you dont need to hardcode it. jsut pass the ENV while running the image. Check Docker Variables for reference.

@AritraDey-Dev

pooranjoyb · 2025-02-15T18:15:02Z

controllers/auth.controller.js

Remove unnecessary LOC or formatting.

pooranjoyb · 2025-02-15T18:15:39Z

docker-compose.yml

+    restart: always
+    ports:
+      - "27017:27017"
+    environment:


these shouldn't be hardcoded. but should be passed as the environment vars.

Remove this @AritraDey-Dev

pooranjoyb · 2025-02-15T18:16:00Z

views/pages/profile.ejs

Remove factoring.

pooranjoyb · 2025-02-15T18:16:49Z

squash all commits in 1 commit. @AritraDey-Dev

AritraDey-Dev · 2025-02-16T18:41:44Z

@pooranjoyb Here are the things we need to do for docker setup.

write a docker file.
in dockeffile we have to build the node Image only.
pass the env file while setting up docker locally.
finally the command should look something like this docker build --env_file=.env -p 8080:8080 -t web .
Please review once i am correct or not.

pooranjoyb · 2025-02-16T19:19:18Z

@pooranjoyb Here are the things we need to do for docker setup.

* write a docker file.

* in dockeffile we have to build the node Image only.

* pass the env file while setting up docker locally.

* finally the command should look something like this `docker build  --env_file=.env -p 8080:8080 -t web .`
  Please review once i am correct or not.

LGTM 👍🏼

pooranjoyb · 2025-02-17T06:46:55Z

README.md


 GEMINI_API_ENDPOINT=https://generativelanguage.googleapis.com/v1beta/models/gemini-1.5-flash-latest:generateContent
 GEMINI_API_KEY=<gemini-api-key>
+NODE_ENV=development


Remove this

README.md

pooranjoyb · 2025-02-17T13:12:40Z

Squash the commits in 1. @AritraDey-Dev

This reverts commit c23e3ae, reversing changes made to bf4d96b. fix: issue in setup

AritraDey-Dev · 2025-02-17T13:19:16Z

Squash the commits in 1. @AritraDey-Dev

yes done.

pooranjoyb · 2025-02-18T16:57:55Z

The build is failing please check. I could see that it is able to pull only node:13
please lemme know which versions are you running?

AritraDey-Dev · 2025-02-18T18:04:11Z

i tried again locally,it is working for me.Make sure you are logged in to dockerHub.
Do docker login
https://forums.docker.com/t/help-on-error-internal-load-metadata-for-docker-io-library-node-18-alpine/144360
I think you are not logged in to docker hub may be that is the issue.

AritraDey-Dev · 2025-02-18T18:42:11Z

Screencast.from.2025-02-19.00-11-03.webm

AritraDey-Dev · 2025-02-18T18:46:46Z

Screencast.from.2025-02-19.00-11-03.webm

@pooranjoyb can you check try to update docker in your system if docker login doesn't work.
also try to run this cmd to check whether docker running properly or not sudo systemctl status docker

pooranjoyb · 2025-02-19T14:15:32Z

Screencast.from.2025-02-19.00-11-03.webm

@pooranjoyb can you check try to update docker in your system if docker login doesn't work. also try to run this cmd to check whether docker running properly or not sudo systemctl status docker

Yes that was docker cache that was creating the issue. anyways, docker is working fine now. jsut had few issues.
Please debug this one.

the auth is failing and that leads to app crash.
also please remove the npm run dev instead create a script for start, and map it with node app.js, we shouldn't use dev in docker

AritraDey-Dev · 2025-02-19T17:43:06Z

Screencast from 2025-02-19 23-08-24.webm
it is working fine in my side.
@pooranjoyb can you show logs of after crashing?it will help me to debug.

AritraDey-Dev · 2025-02-20T16:58:16Z

@pooranjoyb also can you check whether it's able to connect to the db as sometimes in docker this issue is pretty regular.

AritraDey-Dev · 2025-02-23T19:33:26Z

@pooranjoyb any update on this?

pooranjoyb · 2025-02-24T08:06:50Z

Will update accordingly. You can proceed with other issues if any.

AritraDey-Dev · 2025-04-02T06:33:03Z

@pooranjoyb @sristy17 any update regarding this PR? Can this be merged?

sristy17 reviewed Feb 13, 2025

View reviewed changes

sristy17 reviewed Feb 14, 2025

View reviewed changes

sristy17 requested a review from pooranjoyb February 14, 2025 17:08

sristy17 added dwoc-2025 Issue under DWOC 2025 level 3 labels Feb 14, 2025

pooranjoyb requested changes Feb 15, 2025

View reviewed changes

AritraDey-Dev force-pushed the feat/docker branch from be8da9d to 488ee78 Compare February 15, 2025 22:06

AritraDey-Dev force-pushed the feat/docker branch 3 times, most recently from a96cbbb to 4a86011 Compare February 16, 2025 20:21

AritraDey-Dev requested a review from pooranjoyb February 16, 2025 20:36

pooranjoyb requested changes Feb 17, 2025

View reviewed changes

AritraDey-Dev requested a review from pooranjoyb February 17, 2025 08:12

pooranjoyb approved these changes Feb 17, 2025

View reviewed changes

feat(docker): added docker for easy local setup

5ef262d

This reverts commit c23e3ae, reversing changes made to bf4d96b. fix: issue in setup

AritraDey-Dev force-pushed the feat/docker branch from d027bf0 to 5ef262d Compare February 17, 2025 13:18

AritraDey-Dev requested a review from pooranjoyb February 19, 2025 18:42

AritraDey-Dev requested a review from sristy17 February 21, 2025 22:43

pooranjoyb approved these changes Apr 2, 2025

View reviewed changes

pooranjoyb merged commit 585c366 into sristy17:dwoc-2025 Apr 2, 2025

AritraDey-Dev deleted the feat/docker branch April 17, 2025 20:02

Comments

Conversation

AritraDey-Dev commented Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fixes Issue #103

Changes proposed

Check List (Check all the applicable boxes)

Screenshots

Uh oh!

sristy17 left a comment

Choose a reason for hiding this comment

Uh oh!

sristy17 left a comment

Choose a reason for hiding this comment

Uh oh!

AritraDey-Dev commented Feb 14, 2025

Uh oh!

sristy17 commented Feb 14, 2025

Uh oh!

AritraDey-Dev commented Feb 14, 2025

Uh oh!

AritraDey-Dev commented Feb 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AritraDey-Dev Feb 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pooranjoyb commented Feb 15, 2025

Uh oh!

AritraDey-Dev commented Feb 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pooranjoyb commented Feb 16, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pooranjoyb commented Feb 17, 2025

Uh oh!

AritraDey-Dev commented Feb 17, 2025

Uh oh!

pooranjoyb commented Feb 18, 2025

Uh oh!

AritraDey-Dev commented Feb 18, 2025

Uh oh!

AritraDey-Dev commented Feb 18, 2025

Uh oh!

AritraDey-Dev commented Feb 18, 2025

Uh oh!

pooranjoyb commented Feb 19, 2025

Uh oh!

AritraDey-Dev commented Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AritraDey-Dev commented Feb 20, 2025

Uh oh!

AritraDey-Dev commented Feb 13, 2025 •

edited

Loading

AritraDey-Dev commented Feb 14, 2025 •

edited

Loading

AritraDey-Dev Feb 16, 2025 •

edited

Loading

AritraDey-Dev commented Feb 16, 2025 •

edited

Loading

AritraDey-Dev commented Feb 19, 2025 •

edited

Loading