Skip to content

Comments

feat: implemented follow up questions for chat bot#96

Merged
sristy17 merged 1 commit intosristy17:dwoc-2025from
AritraDey-Dev:feat/chatbot-followup-question
Feb 4, 2025
Merged

feat: implemented follow up questions for chat bot#96
sristy17 merged 1 commit intosristy17:dwoc-2025from
AritraDey-Dev:feat/chatbot-followup-question

Conversation

@AritraDey-Dev
Copy link
Contributor

@AritraDey-Dev AritraDey-Dev commented Feb 3, 2025

Fixes Issue #86

Changes proposed

Implemented a session to store question for chat bot.

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Screencast.from.2025-02-02.19-51-51.webm

Copy link
Owner

@sristy17 sristy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @AritraDey-Dev! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@pooranjoyb
Copy link
Collaborator

I guess we can remove the session data when user logs out right? Otherwise we are just increasing the TTFB from server.
@AritraDey-Dev

@AritraDey-Dev
Copy link
Contributor Author

@pooranjoyb that thing we are doing inside the logout function already right.
Screenshot from 2025-02-04 00-20-39

@pooranjoyb
Copy link
Collaborator

Cool, will review and let you know :))
Nice work 👍🏼

@AritraDey-Dev
Copy link
Contributor Author

@pooranjoyb do you think anything extra can be added to this or this works fine?

@pooranjoyb
Copy link
Collaborator

@pooranjoyb do you think anything extra can be added to this or this works fine?

This LGTM, @sristy17 do lemme know your thoughts.

@pooranjoyb pooranjoyb requested a review from sristy17 February 3, 2025 18:55
@sristy17 sristy17 added dwoc-2025 Issue under DWOC 2025 level 3 labels Feb 4, 2025
@sristy17 sristy17 merged commit 51ae2a3 into sristy17:dwoc-2025 Feb 4, 2025
1 check passed
@AritraDey-Dev AritraDey-Dev deleted the feat/chatbot-followup-question branch April 17, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dwoc-2025 Issue under DWOC 2025 level 3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants