Fixes for Python 3.3 and 3.4 #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wr_long doesn't seem to exist, but neither of these names are used in the module anyway.
The name is also in the code object, so for now the name from the stack is ignored; this seems to work OK.
This combines TryExcept and TryFinally handlers from earlier versions. Try is used in Python 3.3 and above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these fixes, depyc works on itself on Python 3.4.
MAKE_FUNCTIONnow expects a name on the top of the stack, then the code object. The name appears to be redundant with the name embedded in the code object, so for now I discard it.TryExceptandTryFinallyAST nodes were unified into a singleTrynode. Added support for this.I'm assuming that there's no need to support Python 3 versions earlier than 3.3; if there is, extra branches will be needed for that.
All the affected code is in py3op functions, so operation on Python 2 should be unaffected.