Conversation
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1292 +/- ##
===========================================
+ Coverage 87.07% 87.13% +0.05%
===========================================
Files 96 97 +1
Lines 3389 3420 +31
Branches 399 406 +7
===========================================
+ Hits 2951 2980 +29
- Misses 367 368 +1
- Partials 71 72 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ponyisi
requested review from
ArturU043,
BenGalewsky,
MattShirley and
gordonwatts
Contributor
|
When I deploy this I get: |
Contributor
|
I did update the deployment template to apply resource limit and request settings as we've done to all other pods |
Contributor
|
Can you provide suggestions on how to test this? |
MattShirley
reviewed
Feb 3, 2026
| enabled: true | ||
| image: sslhep/servicex-did-finder-atlasopenmagic | ||
| pullPolicy: Always | ||
| tag: develop |
Collaborator
There was a problem hiding this comment.
This tag does not currently exist: https://hub.docker.com/r/sslhep/servicex-did-finder-atlasopenmagic/tags
Collaborator
Author
There was a problem hiding this comment.
It will once PR is accepted
MattShirley
reviewed
Feb 3, 2026
| uses: actions/setup-python@v6.2.0 | ||
| with: | ||
| python-version: ${{ matrix.python-version }} | ||
| python-version: | |
Collaborator
There was a problem hiding this comment.
Why are we removing the template arguments here?
Collaborator
Author
There was a problem hiding this comment.
So I would like this DID finder to use Python 3.14; poetry will complain if it can't set up the appropriate release, so we need both Python 3.14 and 3.10 in the test environment (3.10 for the other servicex containers). Since we pin to specific Python versions by poetry, there is no value in iterating over a matrix of python versions; rather we just need to make all relevant python versions available at once.
Collaborator
I also get this error when setting the image tag to |
Collaborator
Author
|
@BenGalewsky @MattShirley logging issues should be fixed by latest push |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1306
Adds an
atlasopenmagicDID finder to the backend (will need a frontend update for proper support in the client). Gives the list of URLs reported by theatlasopenmagicpackage for a givenrelease/dataset[/skim]combination.