Stable haskell/ci speedup #132
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasufell
force-pushed
the
stable-haskell/CI-speedup
branch
from
0d88988 to
8e7a122
Compare
hasufell
force-pushed
the
stable-haskell/CI-speedup
branch
from
8e7a122 to
e3d7bb1
Compare
Since we now don't provide cabal anymore.
hasufell
force-pushed
the
stable-haskell/CI-speedup
branch
from
e3d7bb1 to
016a471
Compare
e.g.: make CABAL=$(./build-cabal.sh) One can also set CABAL0_ARGS environment variable.
hasufell
force-pushed
the
stable-haskell/CI-speedup
branch
from
7d3c68d to
09a560e
Compare
angerman
requested changes
Dec 12, 2025
angerman
left a comment
angerman
left a comment
There was a problem hiding this comment.
Amazing! Let's please separate the Makefile changes into a separate PR, and have this be only release ci configuration changes.
Member
Author
|
@angerman that doesn't make sense. The Makefile changes are prerequisites to be able to use a system cabal. |
|
By changing the Makefile you broke part of the CI. |
Member
Author
Then that has to be fixed as part of this PR. |
hasufell
force-pushed
the
stable-haskell/CI-speedup
branch
3 times, most recently
from
99b1381 to
18737b8
Compare
Member
Why is this saving time? |
hasufell
force-pushed
the
stable-haskell/CI-speedup
branch
3 times, most recently
from
f11b4e4 to
cd9d99c
Compare
We should now be able to build stage2 by pointing to an appropriate stage1 anywhere in PATH. We also provide the ability to bindist stage1.
hasufell
force-pushed
the
stable-haskell/CI-speedup
branch
from
cd9d99c to
cce6bb1
Compare
hasufell
force-pushed
the
stable-haskell/CI-speedup
branch
from
2ee3eee to
ce8cdb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far seems to have saved 7 minutes