25.2.18 updatedkey.cfg path and set provider #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HejiaZ2023
reviewed
Feb 19, 2025
src/mage_rtl/gen_config.py
Outdated
| except Exception as e: | ||
| err_msgs.append(str(e)) | ||
| """ else: | ||
| raise Exception( |
Contributor
There was a problem hiding this comment.
Did you just commented the only raise here? We still want to raise exception if the llm with specified provider don't work.
Also the err_msgs looks no longer necessary.
tests/test_top_agent.py
Outdated
| # llm = get_llm(model=args.model, api_key=cfg["ANTHROPIC_API_KEY"], max_tokens=8192) | ||
| # llm = get_llm(args_d=args_dict) | ||
|
|
||
| api_key_cfg = "" |
Contributor
There was a problem hiding this comment.
I'm not quite against your initial idea of moving cfg into get_llm; (Just don't directly use args_dict)
These lines (155-164) do look irrelevant with other contents in main() and could be wrapped in get_llm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.