Skip to content
This repository was archived by the owner on Mar 18, 2021. It is now read-only.

Fix #899: Don't try to rename ops ids from ManagedObjectController subclasses #900

Open
point-source wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix #899: Don't try to rename ops ids from ManagedObjectController subclasses #900

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3fe249
Fix #899: Only modify ops keys if they exist
point-source Oct 1, 2020
4d83843
Don't create erroneously duplicated params
point-source Oct 2, 2020
ebcc20b
Explicit > implicit
point-source Oct 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 26 additions & 11 deletions aqueduct/lib/src/http/managed_object_controller.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,17 +414,32 @@ class ManagedObjectController<InstanceType extends ManagedObject>

final entityName = _query.entity.name;

if ((path.parameters
?.where((p) => p.location == APIParameterLocation.path)
?.length ??
0) >
0) {
ops["get"].id = "get$entityName";
ops["put"].id = "update$entityName";
ops["delete"].id = "delete$entityName";
} else {
ops["get"].id = "get${entityName}s";
ops["post"].id = "create$entityName";
final int paramLength = path.parameters
?.where((p) => p.location == APIParameterLocation.path)
?.length ??
0;

if (paramLength < 2) {
for (var o in ops.keys) {
switch (ops[o].id) {
case "getObject":
ops[o].id = "get$entityName";
break;
case "getObjects":
ops[o].id = "get${entityName}s";
break;
case "createObject":
ops[o].id = "create$entityName";
break;
case "updateObject":
ops[o].id = "update$entityName";
break;
case "deleteObject":
ops[o].id = "delete$entityName";
break;
default:
}
}
}

return ops;
Expand Down