Fix TOFU ssh key prompt in OpenOnDemand web shell for IPA hosts

[sjpb]

The appliance defaults the host to use for the Open Ondemand web shell to localhost, because it defaults the openondemand group to the login group. However for FreeIPA-enroled hosts, ssh key checks are done against an IPA-controlled known hosts file (which does not include localhost) so the keyscan task is not effective.

However as the IPA-controlled known hosts file does include all IPA hosts, by changing the web shell host to an actual hostname, the user does not have to accept the key on first use.

[elelaysh]

could we set it to always be inventory_hostname?

[sjpb]

could we set it to always be inventory_hostname?

Hmm, that's a good question. There was a reason we changed it to localhost but I cannot remember what. I will do some git blaming ...

[elelaysh]

could we set it to always be inventory_hostname?

Hmm, that's a good question. There was a reason we changed it to localhost but I cannot remember what. I will do some git blaming ...

Back in 2023 (35ba408) it was made configurable, from the ffirst login host

[sjpb]

could we set it to always be inventory_hostname?
Back in 2023 (35ba408) it was made configurable, from the ffirst login host

I think it was probably just that when we made it configurable, localhost was guaranteed to be resolvable (but we could have just moved the api_address bit into the variable, so I'm not sure why we swapped). But inventory_hostname has to be / is anyway (logic here) so yes, I think we should probably just do that always.

[elelaysh]

Good to go