Skip to content

Enable yamllint + key ordering #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
elelaysh wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Enable yamllint + key ordering #874

elelaysh wants to merge 9 commits into from

Conversation

@elelaysh
Copy link
Contributor

@elelaysh elelaysh commented Dec 16, 2025 •
edited
Loading

  • enables yamllint's key_ordering rule to check for bad ordering of manually added repos in environments/common/inventory/group_vars/all/dnf_repo_timestamps.yml.
  • fixes trivial yamllint issues
  • ignores line too long
  • ignores syntax error caused by jinja in a .yml file

@elelaysh elelaysh requested a review from a team as a code owner December 16, 2025 15:19
@elelaysh elelaysh marked this pull request as draft December 16, 2025 15:21
@elelaysh elelaysh force-pushed the feat/yamllint branch 2 times, most recently from 11fa9e6 to 0f6ae70 Compare December 16, 2025 17:07
@elelaysh
Copy link
Contributor Author

elelaysh commented Dec 17, 2025

See wrong key ordering detected

Error: Wrong ordering of key "epel-cisco-openh264" in mapping
Error: Wrong ordering of key "turbovnc" in mapping
Error: Wrong ordering of key "turbovnc-source" in mapping
Error: Wrong ordering of key "cernvmfs_pkgs" in mapping
Error: Wrong ordering of key "cernvmfs_cfg" in mapping

@elelaysh
Copy link
Contributor Author

elelaysh commented Dec 17, 2025 •
edited
Loading

Fixed in d060464: https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/20297650105/job/58295117170?pr=874

@elelaysh elelaysh marked this pull request as ready for review December 17, 2025 09:23
@elelaysh elelaysh changed the title draft: enable yamllint + key ordering enable yamllint + key ordering Dec 18, 2025
@elelaysh elelaysh changed the title enable yamllint + key ordering Enable yamllint + key ordering Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@elelaysh