Fix empty yum.repos.d in overcloud host image #2041
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request fixes a regression where the /etc/yum.repos.d directory was empty in the overcloud host image, preventing package installation. The fix involves setting the DIB_ROCKY_CONTAINER_STACKHPC_RESTORE_UPSTREAM_REPOFILES environment variable to true for diskimage-builder, which correctly restores the yum repository files. The change is logical and directly addresses the issue. My feedback focuses on improving the clarity and accuracy of the new comments added in this PR to enhance future maintainability.
no repos causes installation of tmux fail in terraform-kayobe-multinode. This regression was introduced by commit e0d1d6d
Alex-Welsh
force-pushed
the
fix/overcloud-image-restore-rocky-repos
branch
from
c9f5564 to
6fbedb2
Compare
|
@elelaysh could you also add a release note for this change? It just needs to say something like "The default Rocky 9 overcloud host image has been updated to include upstream package repos out of the box" |
following review Co-authored-by: Alex Welsh <112560678+Alex-Welsh@users.noreply.github.com>
elelaysh
force-pushed
the
fix/overcloud-image-restore-rocky-repos
branch
from
7bf1711 to
d572a80
Compare
|
lgtm but I want to trigger the check-review pipeline, so I've asked @JasleenKaurSethi to approve the PR (which should trigger CI but won't let it merge yet) |
Alex-Welsh
left a comment
Alex-Welsh
left a comment
There was a problem hiding this comment.
Rocky job passed, Ubuntu errors are unrelated
|
thanks |
no repos causes installation of tmux fail in terraform-kayobe-multinode. This regression was introduced by commit e0d1d6d