add support for arbitrary version bytes#15
add support for arbitrary version bytes#15Kefkius wants to merge 2 commits intostacks-archive:masterfrom
Conversation
|
Hi @Kefkius thanks for the suggestions and pull request. I have a few questions:
class KefkiusCoinPrivateKey(BitcoinPrivateKey):
_pubkeyhash_version_byte = 42
kefkius_priv_1 = KefkiusCoinPrivateKey()
kefkius_priv_2 = KefkiusCoinPrivateKey()Here, one can create a new class for a new coin and then create new instances of the class. This is in contrast to your pull request, where you allow users to create new keys without defining a new class.
|
|
@rxl You're welcome. I see that the method you described is at least as useful as mine to a user. I made the pull request after seeing that so many coins were on "to-do" implementation status. I figured this would be an easy little hack to use, but yes, the method you described is just as effective, and may be a better option. As for WIF versions: Yes, I've had to explicitly define a WIF version. |
|
Kefkius seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Add two classes, CoinPrivateKey and CoinPublicKey, that take a version byte parameter in their constructors.
Also allow WIF version byte to be specified via a parameter.