Skip to content

Conversation

@VisruthSK
Copy link
Member

Updating the theme to better match the main Stan page. This PR uses the new theme & use a GitHub Action to automatically build the dev version of the site on PRs and the release version on releases.

@VisruthSK VisruthSK marked this pull request as draft October 29, 2025 16:23
@VisruthSK
Copy link
Member Author

In _pkgdown.yml, 2 topics missing from index: "logit" and "pp_validate".
Either add to the reference index, or use @keywords internal to drop from
the index.

Where should these two reference pages go? They're both exported so I presume the documentation should be published. @jgabry

@jgabry
Copy link
Member

jgabry commented Oct 29, 2025

I think "logit" should go in the "Additional documentation" category in _pkgdown.yml. For pp_validate I think we should eventually deprecate it (the method it uses is outdated), but for now @keywords internal is OK.

@jgabry
Copy link
Member

jgabry commented Oct 29, 2025

(also don't worry about r cmd check failing if it's unrelated to this PR, that's been an issue with rstanarm on GHA)

@VisruthSK
Copy link
Member Author

I think this PR only needs a redocument and it should be good. I'm trying to do so now.

@VisruthSK
Copy link
Member Author

@jgabry

Accidentally built straight to root w/o a dev site, should I revert or just roll with it and fix the logo/favicons? Same question for rstantools

https://mc-stan.org/rstanarm/
https://mc-stan.org/rstantools/

@VisruthSK VisruthSK marked this pull request as ready for review December 2, 2025 04:47
@VisruthSK VisruthSK requested a review from jgabry December 2, 2025 04:51
@jgabry
Copy link
Member

jgabry commented Dec 2, 2025

At this point I think it's fine to roll with it and fix what's necessary, thanks!

@VisruthSK
Copy link
Member Author

I think I may have changed line endings but I reverted any formatting issues

@jgabry
Copy link
Member

jgabry commented Dec 3, 2025

Ok thanks

@VisruthSK
Copy link
Member Author

Also doesn't have a dev site but otherwise seems ok.

@VisruthSK
Copy link
Member Author

Math seems to be fixed at https://mc-stan.org/rstanarm/articles/lm.html, rerunning the build after your changes. Was there anything else that needed to be fixed?

@jgabry
Copy link
Member

jgabry commented Dec 10, 2025

I think that’s it, thanks. I’ll take another look later just to make sure there’s nothing else and if not then I’ll merge it.

@jgabry
Copy link
Member

jgabry commented Dec 10, 2025

I added _pkgdown.yml to .Rbuildignore to avoid an R cmd check NOTE but otherwise I think this is ready to go.

Copy link
Member

@jgabry jgabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @VisruthSK!

@jgabry jgabry merged commit 1b8c4ce into master Dec 10, 2025
3 of 12 checks passed
@jgabry jgabry deleted the New-pkgdown-theme branch December 10, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants