-
-
Notifications
You must be signed in to change notification settings - Fork 137
New pkgdown theme #642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New pkgdown theme #642
Conversation
|
In _pkgdown.yml, 2 topics missing from index: "logit" and "pp_validate". Where should these two reference pages go? They're both exported so I presume the documentation should be published. @jgabry |
|
I think "logit" should go in the "Additional documentation" category in |
|
(also don't worry about r cmd check failing if it's unrelated to this PR, that's been an issue with rstanarm on GHA) |
|
I think this PR only needs a redocument and it should be good. I'm trying to do so now. |
|
Accidentally built straight to root w/o a dev site, should I revert or just roll with it and fix the logo/favicons? Same question for rstantools https://mc-stan.org/rstanarm/ |
|
At this point I think it's fine to roll with it and fix what's necessary, thanks! |
|
I think I may have changed line endings but I reverted any formatting issues |
|
Ok thanks |
|
Also doesn't have a dev site but otherwise seems ok. |
|
Math seems to be fixed at https://mc-stan.org/rstanarm/articles/lm.html, rerunning the build after your changes. Was there anything else that needed to be fixed? |
|
I think that’s it, thanks. I’ll take another look later just to make sure there’s nothing else and if not then I’ll merge it. |
|
I added |
jgabry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @VisruthSK!
Updating the theme to better match the main Stan page. This PR uses the new theme & use a GitHub Action to automatically build the dev version of the site on PRs and the release version on releases.