Skip to content

Avoid indexing past vector length in Pathfinder writer #3364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SteveBronder merged 3 commits into from
Oct 13, 2025
Merged

Avoid indexing past vector length in Pathfinder writer #3364

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f038f1
Avoid indexing past vector length
andrjohns Oct 10, 2025
81f3b45
Merge commit '07585a9e59832696fdb956a5921c647f0e2e47a7' into HEAD
yashikno Oct 11, 2025
f942abc
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/stan/services/pathfinder/multi.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,11 +343,13 @@ inline int pathfinder_lbfgs_multi(
sample_row.tail(uc_param_size) = approx_samples_constrained_col;
safe_write(sample_row);
// If we see the same draw idx more than once, just increment j and
// write again
while (j < (single_path_psis_idxs[i].second)
&& draw_idx == psis_draw_idxs.coeff(j + 1)) {
safe_write(sample_row);
++j;
// write again if there are remaining draws
if (j < (psis_draw_idxs.size() - 1)) {
while (j < (single_path_psis_idxs[i].second)
&& draw_idx == psis_draw_idxs.coeff(j + 1)) {
safe_write(sample_row);
++j;
}
}
}
}
Expand Down