Added improved execution code #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gentlegiantJGC
added a commit
to gentlegiantJGC/xmastree2021
that referenced
this pull request
Jan 6, 2022
Added my sequences. I wrote these using python so I have added the source python files as well as the baked CSV files. I wrote a version of the neopixel library that can be run without the tree. It visualises the tree using matplotlib and has the option to generate the CSV file from the inputs it was given. It also adds the baked CSV files for Matt's tree. Some of these are designed to run at slower frame rates so require standupmaths#30
Author
|
@oliverdunk did you get a chance to look over this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The improved execution code is much more robust than the Harvard execution code.
It finds the contents of the column based on the column name (the old code ignored the column names and assumed the colums were in a specific order.
It will populate any missing columns with default values (the old code would error)
It adds support for an optional
FRAME_TIMEcolumn which allows users to customise how long a frame remains for. If undefined it runs the frames as quickly as the hardware is able to.Added documentation for the animation file format.
Also added a .gitignore
I tried submitting this code to the Harvard repository but they are no longer maintaining the repository.
Discussion for this code can be found in
GSD6338/XmasTree#2
and
GSD6338/XmasTree#4
This should also fix #9