Skip to content

Conversation

@philvarner
Copy link
Contributor

@philvarner philvarner commented Dec 5, 2025

What I'm changing

Currently, the pagination links for Orders and Order Statuses don't have next link relation hrefs with the value returned from url_for, so they're always relative to the server's URL (default) rather than what the implementation has overridden url_for to do.

How I did it

  • the pagination link function calls the url_for function now, so the url is correct

Checklist

  • Tests pass: uv run pytest
  • Checks pass: uv run pre-commit run --all-files
  • CHANGELOG is updated (if necessary)

@philvarner philvarner requested a review from jkeifer December 5, 2025 21:44
@philvarner philvarner changed the title Fix pagination links wrt override of url_for DRAFT Fix pagination links wrt override of url_for Dec 5, 2025
@philvarner philvarner requested a review from wevonosky December 8, 2025 22:45
@philvarner philvarner changed the title DRAFT Fix pagination links wrt override of url_for Fix pagination links for Orders pagination wrt the use of overriding url_for Dec 12, 2025
@philvarner philvarner marked this pull request as ready for review December 12, 2025 20:17
@philvarner philvarner requested a review from gadomski as a code owner December 12, 2025 20:17
@gadomski gadomski removed their request for review December 15, 2025 21:17
@philvarner philvarner requested a review from jkeifer December 17, 2025 01:12
@wevonosky
Copy link
Collaborator

Test comment for @philvarner

@philvarner philvarner merged commit cc07fa0 into main Dec 17, 2025
4 checks passed
@philvarner philvarner deleted the pv/pagination-link-incorrect branch December 17, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants