Skip to content

Fix: Add variables initializers #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renanpupin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Add variables initializers #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions starkcore/utils/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@ exports.fromApiJson = function(resource, json){
};

exports.castJsonToApiFormat = function (json, resourceName) {
clean = [];
let clean = [];
if (json === null) {
return clean;
}
for(const key in json) {
const value = json[key];
let value = json[key];
if (value === null) {
continue;
}
Expand All @@ -37,10 +37,10 @@ exports.castJsonToApiFormat = function (json, resourceName) {
clean[key] = api.castJsonToApiFormat(value, resourceName)
}
clean[key] = value;

return clean;
}
};
};

exports.endpoint = function (resource, keepDash = false) {
let decamelized = decamelize(resource);
Expand All @@ -57,7 +57,7 @@ exports.lastName = function (resource) {
};

exports.lastNamePlural = function (resource) {
lastName = exports.lastName(resource);
let lastName = exports.lastName(resource);
if (lastName.endsWith('s')) {
return lastName;
}
Expand Down
48 changes: 24 additions & 24 deletions starkcore/utils/rest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ const fetch = require('./request.js').fetch;
const { fetchBuffer } = require('./request.js');

exports.getPage = async function (sdkVersion, host, apiVersion, resource, user = null, language, timeout, query = []) {
response = await fetch(
host,
let response = await fetch(
host,
sdkVersion,
user,
'GET',
Expand All @@ -30,7 +30,7 @@ exports.getList = async function* (sdkVersion, host, apiVersion, resource, user
let list;
let cursor = '';
let names = api.lastNamePlural(resource['name']);
limit = query['limit'] ? query['limit'] : null;
let limit = query['limit'] ? query['limit'] : null;
do {
if (!query) {
query = {};
Expand All @@ -45,7 +45,7 @@ exports.getList = async function* (sdkVersion, host, apiVersion, resource, user
'limit': Math.min(100, limit),
'cursor': cursor,
});
response = await fetch(
let response = await fetch(
host,
sdkVersion,
user,
Expand All @@ -70,7 +70,7 @@ exports.getList = async function* (sdkVersion, host, apiVersion, resource, user
};

exports.getId = async function (sdkVersion, host, apiVersion, user = null, resource, id, language, timeout, query = []) {
response = await fetch(
let response = await fetch(
host,
sdkVersion,
user,
Expand All @@ -83,12 +83,12 @@ exports.getId = async function (sdkVersion, host, apiVersion, user = null, resou
timeout
);
let json = response.json();
returnEntity = json[api.lastName(resource['name'])];
let returnEntity = json[api.lastName(resource['name'])];
return Object.assign(new resource['class'](returnEntity), returnEntity);
};

exports.getContent = async function (sdkVersion, host, apiVersion, user, resource, id, subResource, language, timeout, query = []){
response = await fetchBuffer(
let response = await fetchBuffer(
host,
sdkVersion,
user,
Expand All @@ -106,7 +106,7 @@ exports.getContent = async function (sdkVersion, host, apiVersion, user, resourc
exports.getSubResource = async function (sdkVersion, host, apiVersion, user = null, resource, id, subResource, language, timeout) {
let endpoint = `${api.endpoint(resource['name'])}`
let subResourceEndpoint = `${api.endpoint(subResource['name'])}`
response = await fetch(
let response = await fetch(
host,
sdkVersion,
user,
Expand All @@ -124,7 +124,7 @@ exports.getSubResource = async function (sdkVersion, host, apiVersion, user = nu
};

exports.getPublicKey = async function (sdkVersion, host, apiVersion, user, language, timeout) {
response = await fetch(
let response = await fetch(
host,
sdkVersion,
user,
Expand All @@ -133,7 +133,7 @@ exports.getPublicKey = async function (sdkVersion, host, apiVersion, user, langu
null,
{'limit': 1},
apiVersion,
language,
language,
timeout
);
let json = response.json();
Expand All @@ -147,7 +147,7 @@ exports.post = async function (sdkVersion, host, apiVersion, user, resource, ent
}
let payload = {};
payload[names] = entities;
response = await fetch(
let response = await fetch(
host,
sdkVersion,
user,
Expand All @@ -170,7 +170,7 @@ exports.post = async function (sdkVersion, host, apiVersion, user, resource, ent
}

exports.postMulti = async function (sdkVersion, host, apiVersion, user, resource, entities, language, timeout, query) {
response = await fetch(
let response = await fetch(
host,
sdkVersion,
user,
Expand All @@ -192,7 +192,7 @@ exports.postMulti = async function (sdkVersion, host, apiVersion, user, resource
exports.postSingle = async function (sdkVersion, host, apiVersion, user, resource, language, timeout, query) {
let payload = Object.assign(new resource['class']({}), query);
api.removeNullKeys(payload);
response = await fetch(
let response = await fetch(
host,
sdkVersion,
user,
Expand All @@ -205,12 +205,12 @@ exports.postSingle = async function (sdkVersion, host, apiVersion, user, resourc
timeout
);
let json = response.json();
returnEntity = json[api.lastName(resource['name'])];
let returnEntity = json[api.lastName(resource['name'])];
return Object.assign(new resource['class'](returnEntity), returnEntity);
};

exports.postSubResource = async function (sdkVersion, host, apiVersion, user, id, subResource, resource, payload, language, timeout) {
response = await fetch(
let response = await fetch(
host,
sdkVersion,
user,
Expand All @@ -222,12 +222,12 @@ exports.postSubResource = async function (sdkVersion, host, apiVersion, user, id
timeout
)
let json = response.json();
returnEntity = json[api.lastName(subResource)];
let returnEntity = json[api.lastName(subResource)];
return Object.assign(new subResource['class'](returnEntity), returnEntity);
};

exports.deleteId = async function (sdkVersion, host, apiVersion, user, resource, id, language, timeout, query) {
response = await fetch(
let response = await fetch(
host,
sdkVersion,
user,
Expand All @@ -241,13 +241,13 @@ exports.deleteId = async function (sdkVersion, host, apiVersion, user, resource,
timeout
);
let json = response.json();
returnEntity = json[api.lastName(resource['name'])];
let returnEntity = json[api.lastName(resource['name'])];
return Object.assign(new resource['class'](returnEntity), returnEntity);
};

exports.patchId = async function (sdkVersion, host, apiVersion, user, resource, id, payload, language, timeout) {
api.removeNullKeys(payload);
response = await fetch(
let response = await fetch(
host,
sdkVersion,
user,
Expand All @@ -260,12 +260,12 @@ exports.patchId = async function (sdkVersion, host, apiVersion, user, resource,
timeout
)
let json = response.json();
returnEntity = json[api.lastName(resource['name'])];
let returnEntity = json[api.lastName(resource['name'])];
return Object.assign(new resource['class'](returnEntity), returnEntity);
};

exports.getRaw = async function (sdkVersion, host, apiVersion, path, user, language, timeout, query) {
response = await fetch(
let response = await fetch(
host,
sdkVersion,
user,
Expand All @@ -281,8 +281,8 @@ exports.getRaw = async function (sdkVersion, host, apiVersion, path, user, langu
};

exports.postRaw = async function (sdkVersion, host, apiVersion, resource, payload, user, language, timeout, query) {
response = await fetch(
host,
let response = await fetch(
host,
sdkVersion,
user,
"POST",
Expand All @@ -295,4 +295,4 @@ exports.postRaw = async function (sdkVersion, host, apiVersion, resource, payloa
);
let json = response.json();
return json;
};
};