This repository was archived by the owner on Aug 21, 2024. It is now read-only.
fix: contract class version mismatch format#2082
Merged
AvivYossef-starkware merged 1 commit intomain-v0.13.2from Jul 14, 2024
Merged
fix: contract class version mismatch format#2082AvivYossef-starkware merged 1 commit intomain-v0.13.2from
AvivYossef-starkware merged 1 commit intomain-v0.13.2from
Conversation
This was referenced Jul 14, 2024
9848dc2 to
f02c316
Compare
f02c316 to
920cb3e
Compare
dorimedini-starkware
suggested changes
Jul 14, 2024
Collaborator
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware)
crates/blockifier/src/test_utils.rs line 50 at r1 (raw file):
erc20_contract_without_some_syscalls_compiled.json"; // TODO: Aviv(14/7/2024):Move from test utils module, and use it in ContractClassVersionMismatch
Suggestion:
// TODO(Aviv, 14/7/2024): Movecommit-id:2978d6d0
920cb3e to
85d7b78
Compare
Collaborator
Author
AvivYossef-starkware
left a comment
There was a problem hiding this comment.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)
crates/blockifier/src/test_utils.rs line 50 at r1 (raw file):
erc20_contract_without_some_syscalls_compiled.json"; // TODO: Aviv(14/7/2024):Move from test utils module, and use it in ContractClassVersionMismatch
Done.
dorimedini-starkware
approved these changes
Jul 14, 2024
Collaborator
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack:
This change is