apollo_storage: add core batching infrastructure and API #11754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
dean-starkware
force-pushed
the
dean/01-mmap-append-batch
branch
2 times, most recently
from
9916e33 to
250d059
Compare
dean-starkware
force-pushed
the
dean/02-batching-infrastructure
branch
3 times, most recently
from
993165f to
1c4a122
Compare
dean-starkware
force-pushed
the
dean/02-batching-infrastructure
branch
from
1c4a122 to
72dc69a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the core storage batching system:
BatchConfigfor configurable batch sizesPendingWriteenum for queuing operationsStorageWriterbatching logic with auto-flushNote: This PR combines what were originally two separate commits (core batching infrastructure + batch helper functions) into a single commit.
Why merged: The core batching infrastructure introduces the
PendingWriteenum and batching logic, which immediately calls helper methods likeappend_transaction(),append_contract_class(), etc.These helper methods are defined in the second commit. Splitting them into separate PRs would cause compilation errors in the first PR since it references methods that don't exist yet.
To maintain a clean, reviewable PR that compiles independently, both commits were merged into a single logical unit.