added a new feature #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starroli
commented
Feb 28, 2017
| } | ||
| if (args.length > 0) { | ||
| System.out.println("Hello " + String.join(",", args) + "!"); | ||
| System.out.println("How are you?"); |
Owner
Author
There was a problem hiding this comment.
Replace this usage of System.out or System.err by a logger. 
starroli
commented
Feb 28, 2017
| public static void main(String[] args) { | ||
| String alternativeName = "Max"; | ||
| try { | ||
| BigDecimal youShouldNotDoThis = new BigDecimal(1.5d); |
Owner
Author
There was a problem hiding this comment.
Remove this unused "youShouldNotDoThis" local variable.
starroli
commented
Feb 28, 2017
| String alternativeName = "Max"; | ||
| try { | ||
| BigDecimal youShouldNotDoThis = new BigDecimal(1.5d); | ||
| } catch (Throwable throwable) { |
Owner
Author
There was a problem hiding this comment.
Catch Exception instead of Throwable.
starroli
commented
Feb 28, 2017
| try { | ||
| BigDecimal youShouldNotDoThis = new BigDecimal(1.5d); | ||
| } catch (Throwable throwable) { | ||
| System.err.println(throwable); |
Owner
Author
There was a problem hiding this comment.
Replace this usage of System.out or System.err by a logger.
Owner
Author
|
SonarQube analysis reported 4 issues
Watch the comments in this conversation to review them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.