Compiler and documentation cleanup#8
Open
rhizoome wants to merge 3 commits intostefanct:masterfrom
rhizoome:cleanup
Open
Compiler and documentation cleanup#8rhizoome wants to merge 3 commits intostefanct:masterfrom rhizoome:cleanup
rhizoome wants to merge 3 commits intostefanct:masterfrom
rhizoome:cleanup
Conversation
stefanct
reviewed
May 1, 2017
Owner
stefanct
left a comment
There was a problem hiding this comment.
What's the problem with the empty braces?
And why is that dim there in the first place? :)
Contributor
Author
Now its ok, again, gcc seems not decided on the issue. I'll revert it. Since I already added the {}.
Its quite obvious the macro-body has dim and the called macro wants dim. @stefanct I'm quite curious if Marian Vittek wil answer his email. 😄 |
added 3 commits
May 2, 2017 11:07
The datastructure is passed as a pointer not a double-pointer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@stefanct this is minor cleanup.