feat(calendar): add --send-updates flag to update and delete commands #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add --send-updates flag to CalendarUpdateCmd and CalendarDeleteCmd to control notification behavior when modifying or canceling events with attendees. Without this flag, attendees are not notified of updates or cancellations, causing: - Stale events remaining in attendees' calendars - Duplicate/overlapping events when updates are made - Data synchronization issues for systems managing calendars at arm's length Changes: - Add SendUpdates field to CalendarUpdateCmd and CalendarDeleteCmd - Validate SendUpdates value (all, externalOnly, none) - Pass SendUpdates to Patch and Delete API calls - Update truncateParentRecurrence helper to accept sendUpdates parameter - Add tests for validation and API integration Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add TestCalendarSendUpdates Go integration test and shell live test that verify attendee notifications are sent on create/update/delete. Tests are opt-in via GOG_IT_ATTENDEE / GOG_LIVE_CALENDAR_ATTENDEE env vars. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Author
|
Added integration tests for Manual verification completed:
Tests are opt-in via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
--send-updatesflag toCalendarUpdateCmdandCalendarDeleteCmdto control notification behavior when modifying or canceling events with attendeescreatecommand which already has this flagProblem
When updating or deleting calendar events with attendees, the attendees are not notified because the
--send-updatesflag was missing. This causes:Test plan
go test ./internal/cmd/... -run Calendar--send-updatesvalues on update/deleteSendUpdatesis passed to the APIgog calendar create primary --summary "Test" --from ... --to ... --attendees "test@example.com" --send-updates allgog calendar update primary <eventId> --summary "Updated" --send-updates all(attendee should be notified)gog calendar delete primary <eventId> --send-updates all(attendee should be notified of cancellation)🤖 Generated with Claude Code