fix(gmail): fallback to send-as list for display name#184
Open
salmonumbrella wants to merge 3 commits intosteipete:mainfrom
Open
fix(gmail): fallback to send-as list for display name#184salmonumbrella wants to merge 3 commits intosteipete:mainfrom
salmonumbrella wants to merge 3 commits intosteipete:mainfrom
Conversation
The condition `primary == nil && sa.IsPrimary` inside the email-matching block can never be true because `primary` is already unconditionally set to `sa` when `sa.IsPrimary` is true earlier in the same loop iteration. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SendAs.Getreturns an empty display name, fall back to querying theSendAs.Listendpoint to retrieve it--fromalias path and the default primary-account pathprimarySendAsDisplayName,sendAsDisplayNameFromList,primarySendAsDisplayNameFromListprimarySendAsDisplayNameFromListFixes #182
Test plan
TestGmailSendCmd_RunJSON_WithFromstill passes (Get returns display name directly)TestGmailSendCmd_RunJSON_PrimaryAccountDisplayNamestill passesTestGmailSendCmd_RunJSON_PrimaryAccountDisplayNameFallbackToList— primary account path falls back to ListTestGmailSendCmd_RunJSON_WithFromDisplayNameFallbackToList—--fromalias path falls back to ListTestGmailSendCmd_RunJSON_PrimaryAccountNoDisplayName— graceful when no name anywherego test ./...)🤖 Generated with Claude Code