Draft
Conversation
422f479 to
4b125da
Compare
JiahuiWho
reviewed
Jun 18, 2025
scripts/testnet_reset.sh
Outdated
| log_warning "Failed to create Anchor USDC trustline for $account_var" | ||
| fi | ||
|
|
||
| if stellar tx new change-trust \ |
Contributor
There was a problem hiding this comment.
Just curious. Do all these test accounts need a trustline to Circle USDC? I thought only the distribution account would need it, like we do for SRT.
Contributor
Author
There was a problem hiding this comment.
Yeah, you're right. Fixed.
lijamie98
approved these changes
Jun 20, 2025
Contributor
|
The PR looks fine to me overall. I don't see the script where we check the circle USDC balance though. (here) Is it no longer needed in our tests? |
Contributor
|
Can we add a GH action to run the testnet reset? |
lijamie98
suggested changes
Jun 23, 2025
|
|
||
| # USDC issuer | ||
| USDC_ISSUER_SECRET= | ||
| USDC_ISSUER_PUBLIC= |
Contributor
There was a problem hiding this comment.
The .env should not have PUBLIC keys. They can be generated from the secret.
b0811f9 to
4402839
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates
testnet_reset.sh.Context
It previously only deployed the contracts.
Testing
Documentation
N/A
Known limitations
N/A