-
Notifications
You must be signed in to change notification settings - Fork 43
CHORE: Convert ServiceRunner to Kotlin #1879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lijamie98
wants to merge
3
commits into
develop
Choose a base branch
from
chore/convert-service-runner-to-kotlin
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,205 @@ | ||
| { | ||
| "version": "0.2.0", | ||
| "configurations": [ | ||
| { | ||
| "type": "java", | ||
| "name": "Sep Server: default", | ||
| "request": "launch", | ||
| "mainClass": "org.stellar.anchor.platform.run_profiles.RunSepServer", | ||
| "envFile": "${workspaceFolder}/.env", | ||
| "console": "internalConsole", | ||
| "internalConsoleOptions": "openOnSessionStart" | ||
| }, | ||
| { | ||
| "type": "java", | ||
| "name": "Platform Server: default", | ||
| "request": "launch", | ||
| "mainClass": "org.stellar.anchor.platform.run_profiles.RunPlatformServer", | ||
| "envFile": "${workspaceFolder}/.env", | ||
| "console": "internalConsole", | ||
| "internalConsoleOptions": "openOnSessionStart" | ||
| }, | ||
| { | ||
| "type": "java", | ||
| "name": "Custody Server: custody", | ||
| "request": "launch", | ||
| "mainClass": "org.stellar.anchor.platform.run_profiles.RunCustodyServer", | ||
| "envFile": "${workspaceFolder}/.env", | ||
| "console": "internalConsole", | ||
| "internalConsoleOptions": "openOnSessionStart" | ||
| }, | ||
| { | ||
| "type": "java", | ||
| "name": "Event Processing Server: default", | ||
| "request": "launch", | ||
| "mainClass": "org.stellar.anchor.platform.run_profiles.RunEventProcessingServer", | ||
| "envFile": "${workspaceFolder}/.env", | ||
| "console": "internalConsole", | ||
| "internalConsoleOptions": "openOnSessionStart" | ||
| }, | ||
| { | ||
| "type": "java", | ||
| "name": "Horizon Observer: default", | ||
| "request": "launch", | ||
| "mainClass": "org.stellar.anchor.platform.run_profiles.RunStellarObserver", | ||
| "envFile": "${workspaceFolder}/.env", | ||
| "console": "internalConsole", | ||
| "internalConsoleOptions": "openOnSessionStart" | ||
| }, | ||
| { | ||
| "type": "java", | ||
| "name": "Soroban Observer: default", | ||
| "request": "launch", | ||
| "mainClass": "org.stellar.anchor.platform.run_profiles.RunStellarObserver", | ||
| "envFile": "${workspaceFolder}/.env", | ||
| "env": { | ||
| "stellar_network.rpc_url": "https://soroban-testnet.stellar.org" | ||
| } | ||
| }, | ||
| { | ||
| "type": "java", | ||
| "name": "Reference Server: default", | ||
| "request": "launch", | ||
| "mainClass": "org.stellar.anchor.platform.run_profiles.RunKotlinReferenceServer", | ||
| "envFile": "${workspaceFolder}/.env", | ||
| "env": { | ||
| "TEST_PROFILE_NAME": "default" | ||
| } | ||
| }, | ||
| { | ||
| "type": "java", | ||
| "name": "Wallet Reference Server: default", | ||
| "request": "launch", | ||
| "mainClass": "org.stellar.anchor.platform.run_profiles.RunWalletServer", | ||
| "envFile": "${workspaceFolder}/.env", | ||
| "console": "internalConsole", | ||
| "internalConsoleOptions": "openOnSessionStart" | ||
| }, | ||
| { | ||
| "type": "java", | ||
| "name": "Docker - Run Dev Stack - Kafka, Postgres, SEP24 Reference UI", | ||
| "request": "launch", | ||
| "mainClass": "org.stellar.anchor.platform.run_profiles.RunDockerDevStack", | ||
| "console": "internalConsole", | ||
| "internalConsoleOptions": "openOnSessionStart" | ||
| }, | ||
| { | ||
| "type": "java", | ||
| "name": "Test Profile: default", | ||
| "request": "launch", | ||
| "mainClass": "org.stellar.anchor.platform.run_profiles.RunTestProfile", | ||
| "envFile": "${workspaceFolder}/.env", | ||
| "console": "internalConsole", | ||
| "internalConsoleOptions": "openOnSessionStart" | ||
| }, | ||
| { | ||
| "type": "java", | ||
| "name": "Test Profile: default - horizon", | ||
| "request": "launch", | ||
| "mainClass": "org.stellar.anchor.platform.run_profiles.RunTestProfile", | ||
| "envFile": "${workspaceFolder}/.env", | ||
| "env": { | ||
| "TEST_PROFILE_NAME": "default-horizon" | ||
| } | ||
| }, | ||
| { | ||
| "type": "java", | ||
| "name": "Test Profile: auth-apikey-custody", | ||
| "request": "launch", | ||
| "mainClass": "org.stellar.anchor.platform.run_profiles.RunTestProfile", | ||
| "envFile": "${workspaceFolder}/.env", | ||
| "env": { | ||
| "TEST_PROFILE_NAME": "auth-apikey-custody" | ||
| } | ||
| }, | ||
| { | ||
| "type": "java", | ||
| "name": "Test Profile: auth-apikey-platform", | ||
| "request": "launch", | ||
| "mainClass": "org.stellar.anchor.platform.run_profiles.RunTestProfile", | ||
| "envFile": "${workspaceFolder}/.env", | ||
| "env": { | ||
| "TEST_PROFILE_NAME": "auth-apikey-platform" | ||
| } | ||
| }, | ||
| { | ||
| "type": "java", | ||
| "name": "Test Profile: auth-jwt-custody", | ||
| "request": "launch", | ||
| "mainClass": "org.stellar.anchor.platform.run_profiles.RunTestProfile", | ||
| "envFile": "${workspaceFolder}/.env", | ||
| "env": { | ||
| "TEST_PROFILE_NAME": "auth-jwt-custody" | ||
| } | ||
| }, | ||
| { | ||
| "type": "java", | ||
| "name": "Test Profile: auth-jwt-platform", | ||
| "request": "launch", | ||
| "mainClass": "org.stellar.anchor.platform.run_profiles.RunTestProfile", | ||
| "envFile": "${workspaceFolder}/.env", | ||
| "env": { | ||
| "TEST_PROFILE_NAME": "auth-jwt-platform" | ||
| } | ||
| }, | ||
| { | ||
| "type": "java", | ||
| "name": "Test Profile: custody", | ||
| "request": "launch", | ||
| "mainClass": "org.stellar.anchor.platform.run_profiles.RunTestProfile", | ||
| "envFile": "${workspaceFolder}/.env", | ||
| "env": { | ||
| "TEST_PROFILE_NAME": "custody" | ||
| } | ||
| }, | ||
| { | ||
| "type": "java", | ||
| "name": "Test Profile: deployment", | ||
| "request": "launch", | ||
| "mainClass": "org.stellar.anchor.platform.run_profiles.RunTestProfile", | ||
| "envFile": "${workspaceFolder}/.env", | ||
| "env": { | ||
| "TEST_PROFILE_NAME": "deployment" | ||
| } | ||
| }, | ||
| { | ||
| "type": "java", | ||
| "name": "Test Profile: host.docker.internal", | ||
| "request": "launch", | ||
| "mainClass": "org.stellar.anchor.platform.run_profiles.RunTestProfile", | ||
| "envFile": "${workspaceFolder}/.env", | ||
| "console": "internalConsole", | ||
| "internalConsoleOptions": "openOnSessionStart" | ||
| }, | ||
| { | ||
| "type": "java", | ||
| "name": "Test Profile: kafka-sasl-ssl", | ||
| "request": "launch", | ||
| "mainClass": "org.stellar.anchor.platform.run_profiles.RunTestProfile", | ||
| "envFile": "${workspaceFolder}/.env", | ||
| "env": { | ||
| "TEST_PROFILE_NAME": "kafka-sasl-ssl" | ||
| } | ||
| }, | ||
| { | ||
| "type": "java", | ||
| "name": "Test Profile: rpc", | ||
| "request": "launch", | ||
| "mainClass": "org.stellar.anchor.platform.run_profiles.RunTestProfile", | ||
| "envFile": "${workspaceFolder}/.env", | ||
| "env": { | ||
| "TEST_PROFILE_NAME": "rpc" | ||
| } | ||
| }, | ||
| { | ||
| "type": "java", | ||
| "name": "Test Profile: soroban-rpc-default", | ||
| "request": "launch", | ||
| "mainClass": "org.stellar.anchor.platform.run_profiles.RunTestProfile", | ||
| "envFile": "${workspaceFolder}/.env", | ||
| "env": { | ||
| "TEST_PROFILE_NAME": "soroban-rpc-default" | ||
| } | ||
| } | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "java.configuration.updateBuildConfiguration": "automatic", | ||
| "java.debug.settings.enableRunDebugCodeLens": true, | ||
| "java.debug.settings.hotCodeReplace": "auto", | ||
| "java.debug.settings.vmArgs": "", | ||
| "java.compile.nullAnalysis.mode": "automatic", | ||
| "java.configuration.runtimes": [], | ||
| "java.jdt.ls.java.home": "", | ||
| "java.import.gradle.enabled": true, | ||
| "java.import.gradle.wrapper.enabled": true | ||
| } |
Empty file.
Empty file.
159 changes: 0 additions & 159 deletions
159
service-runner/src/main/java/org/stellar/anchor/platform/ServiceRunner.java
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing TEST_PROFILE_NAME environment variable in launch configuration
Medium Severity
The "Test Profile: host.docker.internal" launch configuration doesn't set the
TEST_PROFILE_NAMEenvironment variable. Unlike other test profile configurations (e.g., "default-horizon", "custody") that explicitly setTEST_PROFILE_NAMEin theirenvblock, this configuration is missing it entirely. WithoutTEST_PROFILE_NAMEset tohost-docker-internal, the configuration will run the default profile instead of the intended host-docker-internal profile, causing unexpected behavior for developers who expect the configuration name to match the actual test profile being executed.