Conversation
…550/xdrill-transactions
|
@chowbao : I think it is best to hold-off on this work until:
more details on why here |
|
code looks good. My only question is landing it in
|
Yup I agree. My personal opinion would be a new repo We should discuss that in https://github.com/stellar/go/discussions/5651 cause it's along the same lines as your comment and Syd's comment |
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
CHANGELOG.mdwithin the component folder structure. For example, if I changed horizon, then I updated (services/horizon/CHANGELOG.md. I add a new line item describing the change and reference to this PR. If I don't update a CHANGELOG, I acknowledge this PR's change may not be mentioned in future release notes.semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
https://github.com/stellar/go/issues/5551
xdrill functions for LedgerOperations
Why
Create low level helper functions for operations parsing
Known limitations
This PR replaces chowbao#2