Add options for poddisruptionbudget and affinity in the core, horizon and soroban rpc helm charts#125
Merged
travertischio merged 6 commits intostellar:mainfrom Jun 25, 2025
Merged
Conversation
jacekn
reviewed
Jun 20, 2025
Contributor
jacekn
left a comment
jacekn
left a comment
There was a problem hiding this comment.
💡 could we add short help or examples to the values files to make it easier for users?
It could also be worth adding defaults so that we ship PDP and set affinity rules even if users don't explicitly set them. WDYT?
Contributor
Author
I added examples in comments in the default values files. Currently, 2 of the 4 kubernetes resources that would be affected by the pdb and affinities have 1 replica as a default. So we can't set the default for those. My plan here was to try to stay consistent between the charts |
jacekn
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add options for poddisruptionbudget and affinity in the core, horizon and soroban rpc helm charts
Currently there is no option to set up a pdb or affinity for any of these charts. This adds that option
https://github.com/stellar/ops/issues/3858
https://github.com/stellar/ops/issues/3859
https://github.com/stellar/ops/issues/3861