Skip to content

Conversation

@wpalmeri
Copy link
Contributor

Added permissions for OIDC and adjusted npm publish step. Trust relationship added on npm side already.

Added permissions for OIDC and adjusted npm publish step. Trust relationship added on npm side already.
Copilot AI review requested due to automatic review settings January 15, 2026 23:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request migrates the npm publishing workflow from token-based authentication to OIDC (OpenID Connect) trusted publishing, enhancing security by eliminating the need to store long-lived npm tokens as secrets.

Changes:

  • Added OIDC permissions (id-token: write and contents: read) to the workflow
  • Removed the NODE_AUTH_TOKEN environment variable that referenced the npm token secret
Comments suppressed due to low confidence (1)

.github/workflows/npm_publish.yml:23

  • Corrected spelling of 'Depencencies' to 'Dependencies'.
      - name: Install Depencencies

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Jan 15, 2026

Size Change: 0 B

Total Size: 3.47 MB

ℹ️ View Unchanged
Filename Size
dist/stellar-base.js 2.56 MB
dist/stellar-base.min.js 906 kB

compressed-size-action

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Ryang-21 Ryang-21 merged commit f312cf0 into master Jan 22, 2026
8 checks passed
@Ryang-21 Ryang-21 deleted the trusted-npm-publish branch January 22, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants