Simple utils ts migration

config/eslint.config.cjs

@@ -44,6 +44,19 @@ const javascriptConfig = [
     rules: {
       "no-unused-vars": ["error", { caughtErrors: "none" }]
     }
+  },
+  {
+    name: "test/globals",
+    files: ["test/**/*.js"],
+    languageOptions: {
+      globals: {
+        ...globals.mocha,
+        StellarBase: "readonly",
+        expect: "readonly",
+        chai: "readonly",
+        sinon: "readonly"
+      }
+    }
   }
 ];
 

src/operation.js

@@ -1,5 +1,3 @@
-/* eslint-disable no-bitwise */
-
 import { Hyper } from "@stellar/js-xdr";
 import BigNumber from "./util/bignumber";
 import { trimEnd } from "./util/util";

src/operations/set_options.js

@@ -1,5 +1,3 @@
-/* eslint-disable no-param-reassign */
-
 import xdr from "../xdr";
 import { Keypair } from "../keypair";
 import { StrKey } from "../strkey";

src/util/checksum.js → src/util/checksum.ts

@@ -1,4 +1,7 @@
-export function verifyChecksum(expected, actual) {
+export function verifyChecksum(
+  expected: Uint8Array,
+  actual: Uint8Array
+): boolean {
   if (expected.length !== actual.length) {
     return false;
   }

test/unit/util/checksum.test.ts

@@ -0,0 +1,44 @@
+import { describe, it, expect } from "vitest";
+import { verifyChecksum } from "../../../src/util/checksum";
+
+describe("verifyChecksum", () => {
+  it("returns true for identical arrays", () => {
+    const a = new Uint8Array([1, 2, 3]);
+    const b = new Uint8Array([1, 2, 3]);
+    expect(verifyChecksum(a, b)).toBe(true);
+  });
+
+  it("returns false for different contents", () => {
+    const a = new Uint8Array([1, 2, 3]);
+    const b = new Uint8Array([1, 2, 4]);
+    expect(verifyChecksum(a, b)).toBe(false);
+  });
+
+  it("returns false for different lengths", () => {
+    const a = new Uint8Array([1, 2, 3]);
+    const b = new Uint8Array([1, 2]);
+    expect(verifyChecksum(a, b)).toBe(false);
+  });
+
+  it("returns true for two empty arrays", () => {
+    expect(verifyChecksum(new Uint8Array([]), new Uint8Array([]))).toBe(true);
+  });
+
+  it("returns true for single matching byte", () => {
+    expect(verifyChecksum(new Uint8Array([0xff]), new Uint8Array([0xff]))).toBe(
+      true
+    );
+  });
+
+  it("returns false when first byte differs", () => {
+    const a = new Uint8Array([0, 2, 3]);
+    const b = new Uint8Array([1, 2, 3]);
+    expect(verifyChecksum(a, b)).toBe(false);
+  });
+
+  it("returns false when last byte differs", () => {
+    const a = new Uint8Array([1, 2, 3]);
+    const b = new Uint8Array([1, 2, 0]);
+    expect(verifyChecksum(a, b)).toBe(false);
+  });
+});

tsconfig.base.json

@@ -19,7 +19,7 @@
     "noUncheckedIndexedAccess": true,
 
     // JavaScript support
-    "allowJs": true,
+    "allowJs": false,
     "checkJs": false,
 
     // Interop constraints

tsconfig.cjs.json

@@ -10,6 +10,8 @@
     "rootDir": "./src",
     "module": "commonjs",
     "moduleResolution": "node10",
-    "esModuleInterop": true
+    "esModuleInterop": true,
+    "declaration": true,
+    "declarationDir": "./type_validation"
   }
 }

type_validation/util/checksum.d.ts

@@ -0,0 +1 @@
+export declare function verifyChecksum(expected: Uint8Array, actual: Uint8Array): boolean;